Enable job discard, exporter stub, context cancel bug #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikejholly
changed the title
alexcb
reviewed
Apr 16, 2024
|
|
||
| for { | ||
| select { | ||
| case <-ctx.Done(): |
alexcb
reviewed
Apr 16, 2024
solver/simple.go
Outdated
| s.solver.mu.RUnlock() | ||
| return st | ||
| } | ||
| s.solver.mu.RUnlock() |
There was a problem hiding this comment.
should this be done after the call to createState returns? because createState will add the entry into s.solver.actives.
otherwise this feels like a race-condition where two threads both call state and both end up with a key miss.
There was a problem hiding this comment.
I think that's correct. There's a lock around the actives write on L186, but I think you're right about the race after L145. Will update.
alexcb
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests with this version: https://github.com/earthly/earthly/actions/runs/8694146966/job/23851036433?pr=3987