-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix exception on saving many tab groups #28
base: master
Are you sure you want to change the base?
Fix exception on saving many tab groups #28
Conversation
Had used SaveAllTheTabs for VS2017 for a while, gave the published version of this a try for VS2019, having no issues. Thank you for doing this. Here's hoping the PR is accepted. |
So this plug in will no longer suppor VS2017?
Unable to open extension inside VS2017. Was still having issue [#27] which is why I just tried this updated version. |
Problem cause:
The problem arises when user tries to store too many tab groups. Since we store all tab groups (with full paths to all open tabs for each group) in one string and windows registry's max string length is 1MB we pretty quickly reach this limit and registry key storing operation fails.
Solution:
I propose to store each tab group in its own registry key instead of saving all groups in one key.
This way the amount of groups becomes unlimited and length limit for all tabs paths for one group is ~500k (aforementioned 1 MB)
Results:
Here's how the registry storage look like before and after the proposed change:
Important:
This version will save open tabs in different format in registry so previous versions of this extension won't be able to open it (but they could still work with their "old" format).
Additional fixes:
More:
I've also merged this bugfix with MSVC2019 support fix and published it on Open VSIX Gallery.
Feel free to download and test it :)
Resolves #27