Features/add helpers #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gandhi11
force-pushed
the
features/add-helpers
branch
5 times, most recently
from
b6750af to
f108e39
Compare
martinblanchette
suggested changes
Dec 14, 2018
src/LocaleService.php
Outdated
| } | ||
|
|
||
| if (!isset($this->getLocalesAvailable()[$locale])) { | ||
| return ''; |
There was a problem hiding this comment.
Is it a better idea to fallback on the name using getLocaleName method?
src/Blade/LanguageBladeExtension.php
Outdated
|
|
||
| public function isLtr() | ||
| { | ||
| return LaravelTranslation::getCurrentLocaleDirection() === "rtl"; |
| DIRECTORY_SEPARATOR . 'views'; | ||
| } | ||
|
|
||
| private function bootBladeExtensions() |
There was a problem hiding this comment.
🙏 Separate nested foreach in order to make the code readable and much clean.
…e the current locale direction
…re already checking if the local exist
Gandhi11
force-pushed
the
features/add-helpers
branch
from
f358e56 to
fd9672f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for #7 to be merged
Fix #5 and #6