Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add secure area option to generator #340

Merged
merged 10 commits into from
Feb 2, 2020
Merged

add secure area option to generator #340

merged 10 commits into from
Feb 2, 2020

Conversation

duncdrum
Copy link
Collaborator

@duncdrum duncdrum commented Dec 9, 2019

add mysec secure area to generator options.

see #11
close #339

Future work:
see #344
see #345

@duncdrum
Copy link
Collaborator Author

note to self:

HTTP ERROR 500 javax.servlet.ServletException: javax.servlet.ServletException: An error occurred while processing request to /exist/apps/newsec/: err:XPDY0002 variable '$local:login_domain' is not set. [at line 20, column 34, source: /db/apps/newsec/controller.xql]

@duncdrum duncdrum marked this pull request as ready for review December 10, 2019 15:43
@duncdrum duncdrum requested a review from a team December 10, 2019 15:43
Copy link
Member

@line-o line-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would merge both controllers.

@duncdrum
Copy link
Collaborator Author

duncdrum commented Dec 10, 2019

let me rephrase: one controller in the generated app, or one controller template to generate the app files from?

In the first case, I won't have time in the foreseeable future to redesign the mysec reference app but it's a nice improvement, PRs certainly welcome.

In the second case, I was thinking about that, but a single source template file becomes extremely complex and fragile. I sacrificed some DRYness for a comprehensible approach.

@duncdrum duncdrum merged commit 72aaf58 into master Feb 2, 2020
@duncdrum duncdrum deleted the mysec branch February 2, 2020 10:51
@duncdrum
Copy link
Collaborator Author

duncdrum commented Feb 2, 2020

🎉 This PR is included in version 2.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature secure area scaffold using login module
2 participants