If downloading XARs fails, the build should fail #2200
Conversation
|
In principle this is a good idea. However, we should wait to merge this until a new release of the documentation app has been pushed to the public-repo with a fix to the problem described in #2194. Otherwise building the installer will fail... unless we want that to force a fix to #2194 before the next release? (Indeed, this PR isn't a fix to #2194 but will rather help us know when/if it recurs.) |
|
My understanding was that together with eXist-db/public-repo#30 the problem should be fixed, no? |
|
the technical problems are minimal, we just need to come to a decisions about the best steps forward, so we can clear up this and the related PRs elsewhere. |
| @@ -89,14 +89,16 @@ | |||
| </target> | |||
|
|
|||
| <target name="download-xar"> | |||
| <!-- get dest="${apps.dir}" src="${apps.repo}/find?abbrev=${xar}&processor=${project.version}" | |||
| verbose="on" maxtime="180" usetimestamp="true" tryGzipEncoding="true"/ --> | |||
There was a problem hiding this comment.
Should this comment be left? If it's important to leave, please add a comment above explaining what it's here for.
There was a problem hiding this comment.
According to @adamretter:
I did try and previously use the Ant Get Task, unfortunately it is not flexible enough, as it doesn’t tell us the name of the Xar file that will be downloaded, and so we don’t know how to move the file into the autodeploy folder
|
With eXist-db/public-repo#32 merged and active on eXist-db.org this is safe to merge. |
Closes #2194