refs 22658 Recognize history empty when seq_num_min is unknown #5587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an ack is made to the entire history in volatile, since the entries are directly deleted from the history, the check_acked_status method satisfies the condition min_low_mark >= get_seq_num_min() because seq_num_min is unknown as it is empty. This leads to changes being marked for deletion when, in reality, there are none, causing the try_remove method to fail thus causing prepare_change to drop the change because the history was full and changes could not be deleted.
Description
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist