[21821] Update Use Case: How to use eProsima DDS Record and Replay #927
+113
−263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denisa <[email protected]>
Signed-off-by: Denisa <[email protected]>
depink5
force-pushed
the
feature/update_section_15_12
branch
from
435342a
to
4d71184
Compare
depink5
changed the title
rsanchez15
requested changes
Oct 7, 2024
| @@ -5,7 +5,7 @@ SWIG | |||
|
|
|||
| SWIG_ is a development tool that allows connecting programs written in C/C++ with a variety of | |||
| other programming languages, among them Python. | |||
| SWIG 4.0 is required in order to build Fast DDS Python bindings. | |||
| SWIG 4.1 is required in order to build Fast DDS Python bindings. | |||
There was a problem hiding this comment.
Suggested change
| SWIG 4.1 is required in order to build Fast DDS Python bindings. | |
| SWIG version lower than 4.2 is required to build Fast DDS Python bindings. |
| @@ -19,7 +19,7 @@ For Ubuntu, please run: | |||
|
|
|||
| .. code-block:: bash | |||
| sudo apt install swig | |||
| sudo apt install swig4.1 | |||
There was a problem hiding this comment.
This package does not exist for Ubuntu 22. Just add a warning that this is required for Ubuntu 24. I mean, the same command with swig4.1 for ubuntu 24.
See an example on how to create this warnings here
Signed-off-by: Denisa <[email protected]>
rsanchez15
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the section 15.12 in the Fast-DDS documentation to be up to date with the eProsima DDS Record and Replay version.
Contributor Checklist
Reviewer Checklist