Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21684] Update Foxy reference in ROS 2 section #922

Merged
merged 3 commits into from
Oct 1, 2024
Merged

[21684] Update Foxy reference in ROS 2 section #922

merged 3 commits into from
Oct 1, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Oct 1, 2024 •
edited
Loading

Description

This PR updates the ROS 2 section to avoid referring to specific distributions except by highlighting Galactic as EOL.

@Mergifyio backport 2.14.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@JesusPoderoso JesusPoderoso added this to the v3.0.2 milestone Oct 1, 2024
@JesusPoderoso JesusPoderoso self-assigned this Oct 1, 2024
@JesusPoderoso JesusPoderoso removed the request for review from richiprosima October 1, 2024 13:28
MiguelCompany
MiguelCompany requested changes Oct 1, 2024
View reviewed changes
docs/fastdds/ros2/ros2.rst Outdated Show resolved Hide resolved
docs/fastdds/ros2/ros2.rst Outdated Show resolved Hide resolved
MiguelCompany
MiguelCompany previously approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JesusPoderoso
Refs #21684: Uncrustify
4414e9b 
Signed-off-by: eProsima <[email protected]>
@JesusPoderoso JesusPoderoso merged commit 849ac2b into master Oct 1, 2024
4 checks passed
@JesusPoderoso JesusPoderoso deleted the hotfix/ros-references branch October 1, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

@JesusPoderoso JesusPoderoso

Labels
ready-to-merge
Projects
None yet
Milestone
v3.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@JesusPoderoso @MiguelCompany