Skip to content

Commit

Permalink
Update links to open in new tab
Browse files Browse the repository at this point in the history
  • Loading branch information
hoangsvit committed Jan 31, 2024
1 parent 8c1dd5d commit 5c0b215
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 13 deletions.
12 changes: 6 additions & 6 deletions dist/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/helper/markdown/format_markdown.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ let formatMarkdown = function () {
if(twitterUsername === 'undefined value'){
return `No Twitter Username`;
} else {
return `<a href="https://twitter.com/${twitterUsername}">${twitterUsername}</a>`
return `<a target="_blank" href="https://twitter.com/${twitterUsername}">${twitterUsername}</a>`
}
}
let getLocations = function (locationDataModel) {
Expand Down
2 changes: 1 addition & 1 deletion src/helper/markdown/page/create_followers_page.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ let createFollowersPage = (function () {
table = table + `\t<tr>\n`;
table = table + `\t\t<td>${index}</td>\n`;
table = table + `\t\t<td>\n`;
table = table + `\t\t\t<a href="https://github.com/${user.login}">\n`;
table = table + `\t\t\t<a target="_blank" href="https://github.com/${user.login}">\n`;
table = table + `\t\t\t\t<img src="${user.avatarUrl}" width="24" alt="Avatar of ${user.login}"/> ${user.login}\n`;
table = table + `\t\t\t</a><br/>\n`;
table = table + `\t\t\t${formatMarkdown.getName(user.name)}\n`;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ let createPublicContributionsPage = (function () {
table = table + `\t<tr>\n`;
table = table + `\t\t<td>${index}</td>\n`;
table = table + `\t\t<td>\n`;
table = table + `\t\t\t<a href="https://github.com/${user.login}">\n`;
table = table + `\t\t\t<a target="_blank" href="https://github.com/${user.login}">\n`;
table = table + `\t\t\t\t<img src="${user.avatarUrl}" width="24" alt="Avatar of ${user.login}"/> ${user.login}\n`;
table = table + `\t\t\t</a><br/>\n`;
table = table + `\t\t\t${formatMarkdown.getName(user.name)}\n`;
Expand Down
6 changes: 3 additions & 3 deletions src/helper/markdown/page/create_total_contributions_page.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ let createTotalContributionsPage = (function () {
table = table + `\t<tr>\n`;
table = table + `\t\t<td>${index}</td>\n`;
table = table + `\t\t<td>\n`;
table = table + `\t\t\t<a href="https://github.com/${user.login}">\n`;
table = table + `\t\t\t<a target="_blank" href="https://github.com/${user.login}">\n`;
table = table + `\t\t\t\t<img src="${user.avatarUrl}" width="24" alt="Avatar of ${user.login}"/> ${user.login}\n`;
table = table + `\t\t\t</a><br/>\n`;
table = table + `\t\t\t${formatMarkdown.getName(user.name)}\n`;
Expand Down Expand Up @@ -65,13 +65,13 @@ let createTotalContributionsPage = (function () {
markdown = markdown + socialMediaComponent.create(
`Top GitHub Users By Total Contributions in ${country}`,
"List of most active github users based on total contributions by country",
`https://github.com/${outputMarkdownModel.githubUsernameAndRepository}/blob/main/docs/total_contributions/${formatMarkdown.getCountryName(outputMarkdownModel.locationDataModel.country)}.md`);
`https://github.com/${outputMarkdownModel.githubUsernameAndRepository}/blob/main/docs/total-contributions/${formatMarkdown.getCountryName(outputMarkdownModel.locationDataModel.country)}.md`);
markdown = markdown + createUserTableByPublicContributions(outputMarkdownModel.readCacheResponseModel);
markdown = markdown + `### 🚀 Share on\n\n`;
markdown = markdown + socialMediaComponent.create(
`Top GitHub Users By Total Contributions in ${country}`,
`List of most active github users based on total contributions by country`,
`https://github.com/${outputMarkdownModel.githubUsernameAndRepository}/blob/main/docs/total_contributions/${formatMarkdown.getCountryName(outputMarkdownModel.locationDataModel.country)}.md`);
`https://github.com/${outputMarkdownModel.githubUsernameAndRepository}/blob/main/docs/total-contributions/${formatMarkdown.getCountryName(outputMarkdownModel.locationDataModel.country)}.md`);
markdown = markdown + thirdPartyComponent.create();
markdown = markdown + licenseComponent.create(outputMarkdownModel.githubUsernameAndRepository);
return markdown;
Expand Down

0 comments on commit 5c0b215

Please sign in to comment.