Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support pnpm workspaces #14

Merged
merged 1 commit into from
Apr 5, 2021
Merged

feat: support pnpm workspaces #14

merged 1 commit into from
Apr 5, 2021

Conversation

MKruschke
Copy link
Member

@MKruschke MKruschke commented Apr 3, 2021

Why the change

Supporting pnpm workspaces #10

Note: Referencing workspace packages through aliases is not supported with that PR. See more #13

What is the change

  • detection of pnpm-workspace.yaml
  • handle possible ignore pattern

How to test

  • automated test should have passed

Note: windows environment isn't working so I disabled it and try to fix it afterwards -> #15

@MKruschke MKruschke force-pushed the pnpm-support branch 16 times, most recently from 2edd1b4 to 749746d Compare April 4, 2021 01:03
@juanpicado juanpicado self-requested a review April 4, 2021 05:45
Copy link
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Proof of concept, I need still polish the setup, but works fine. 👏🏼
verdaccio/verdaccio#2168

@MKruschke MKruschke merged commit 0bfbff9 into master Apr 5, 2021
@MKruschke MKruschke deleted the pnpm-support branch April 5, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants