Skip to content
This repository has been archived by the owner on Jan 1, 2019. It is now read-only.

Update AKKA to the lastest version ,add support http method for Trace… #67

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

tigerqiu712
Copy link

… Patch and Connect

@codecov-io
Copy link

Codecov Report

Merging #67 into master will decrease coverage by 1.09%.
The diff coverage is 59.61%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #67     +/-   ##
===========================================
- Coverage     95.28%   94.18%   -1.1%     
+ Complexity     1064     1060      -4     
===========================================
  Files            83       83             
  Lines          3370     3388     +18     
  Branches        261      261             
===========================================
- Hits           3211     3191     -20     
- Misses           63       97     +34     
- Partials         96      100      +4
Impacted Files Coverage Δ Complexity Δ
...in/java/io/parallec/core/resources/HttpMethod.java 100% <100%> (ø) 1 <0> (ø) ⬇️
...ec/core/resources/AsyncHttpClientFactoryEmbed.java 90% <100%> (-1.67%) 5 <0> (ø)
src/main/java/io/parallec/core/ParallelClient.java 84.03% <37.5%> (-12.13%) 26 <1> (ø)
...c/main/java/io/parallec/core/actor/HttpWorker.java 81.53% <72.72%> (-12.01%) 29 <0> (-2)
...rc/main/java/io/parallec/core/actor/UdpWorker.java 90.62% <0%> (-5.47%) 18% <0%> (-2%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85052a3...da87d16. Read the comment docs.

@jeffpeiyt
Copy link
Contributor

@tigerqiu712 thanks so much for the nice contribution!

Sorry is busy this week, will definitely take a look on this weekend. In the meantime, could you add some test on the new code to keep the same coverage?

thanks,

@jeffpeiyt
Copy link
Contributor

@tigerqiu712 thanks so much for adding the test cases! Could you please help to take a look at the failed test cases and fix the tests?

@jeffpeiyt
Copy link
Contributor

jeffpeiyt commented Aug 6, 2017

@tigerqiu712 I saw your local repo https://github.com/tigerqiu712/parallec does not have the latest updates. Could you also pull from the latest code, like https://stackoverflow.com/questions/3903817/pull-new-updates-from-original-github-repository-into-forked-github-repository ? Hope that may help you to resolve some tests.

also squash all of your commits to a single one, and I can rebase based on that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants