Skip to content

Commit

Permalink
Merge pull request #2318 from eBay/changeset-release/14.5.0
Browse files Browse the repository at this point in the history
ci: release (next)
  • Loading branch information
ArtBlue authored Nov 26, 2024
2 parents 4d5f4ae + a9d64ad commit f49da92
Show file tree
Hide file tree
Showing 17 changed files with 74 additions and 22 deletions.
15 changes: 15 additions & 0 deletions .changeset/pre.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"mode": "pre",
"tag": "next",
"initialVersions": {
"@ebay/ebayui-core": "14.4.1"
},
"changesets": [
"famous-peas-own",
"great-ants-watch",
"mighty-buckets-tan",
"plenty-drinks-sniff",
"plenty-tips-perform",
"sixty-bananas-kick"
]
}
18 changes: 18 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,23 @@
# eBayUI-Core Changelog

## 14.5.0-next.0

### Minor Changes

- [#2330](https://github.com/eBay/ebayui-core/pull/2330) [`9ebb7c9`](https://github.com/eBay/ebayui-core/commit/9ebb7c92885b3beef4266639513297e8af74cdd0) Thanks [@LuLaValva](https://github.com/LuLaValva)! - Search header for filter menu & filter menu button

- [#2320](https://github.com/eBay/ebayui-core/pull/2320) [`73ff807`](https://github.com/eBay/ebayui-core/commit/73ff807fa1d9989ece78b9c5482d40b4351e2f49) Thanks [@saiponnada](https://github.com/saiponnada)! - fix(combobox): added viewAllOptions control

- [#2319](https://github.com/eBay/ebayui-core/pull/2319) [`a41ae29`](https://github.com/eBay/ebayui-core/commit/a41ae2928ea9301a6bda8ca5dbce835519777b99) Thanks [@saiponnada](https://github.com/saiponnada)! - feat(carousel): respect reduced-motion during autoplay

- [#2327](https://github.com/eBay/ebayui-core/pull/2327) [`30b5859`](https://github.com/eBay/ebayui-core/commit/30b58590f04f3ef65a96f6026b182b8947e9c964) Thanks [@agliga](https://github.com/agliga)! - ebay-ccd: new component

### Patch Changes

- [#2324](https://github.com/eBay/ebayui-core/pull/2324) [`60ebb19`](https://github.com/eBay/ebayui-core/commit/60ebb196d8dc0f1a2bf443d62c1dedab33987a61) Thanks [@UDAY556](https://github.com/UDAY556)! - Added localization for ebay-video component

- [#2312](https://github.com/eBay/ebayui-core/pull/2312) [`c006353`](https://github.com/eBay/ebayui-core/commit/c00635390b9c302cce10135d2f59b6a22c298019) Thanks [@mikehobi](https://github.com/mikehobi)! - refactor(storybook/examples): fully migrate stories and examples to typescript

## 14.4.1

### Patch Changes
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@ebay/ebayui-core",
"version": "14.4.1",
"version": "14.5.0-next.0",
"description": "Collection of core eBay components; considered to be the building blocks for all composite structures, pages & apps.",
"scripts": {
"installMarkoV5": "npm i marko@5 @marko/compiler@5 --force",
Expand Down
4 changes: 3 additions & 1 deletion src/components/components/ebay-dialog-base/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ interface DialogBaseInput extends Omit<Marko.Input<"div">, `on${string}`> {
"close-button-text"?: AttrString;
"close-button-class"?: AttrClass;
"a11y-close-text"?: AttrString;
"close-button"?: Marko.Renderable | Marko.AttrTag<{ renderBody: Marko.Body }>;
"close-button"?:
| Marko.Renderable
| Marko.AttrTag<{ renderBody: Marko.Body }>;
"is-modal"?: boolean;
"ignore-escape"?: boolean;
"window-type"?: string;
Expand Down
2 changes: 1 addition & 1 deletion src/components/ebay-3d-viewer/3d-viewer.stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ export default {
},
},
},
} ;
};

export const Default = Template.bind({});
Default.args = {
Expand Down
4 changes: 1 addition & 3 deletions src/components/ebay-carousel/carousel.stories.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
import {
buildExtensionTemplate,
} from "../../common/storybook/utils";
import { buildExtensionTemplate } from "../../common/storybook/utils";
import carousel from "./index.marko";
import Readme from "./README.md";
import continiousTemplate from "./examples/continuous.marko";
Expand Down
4 changes: 2 additions & 2 deletions src/components/ebay-carousel/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { processHtmlAttributes } from "../../common/html-attributes";
import { onScrollDebounced as onScroll } from "./utils/on-scroll-debounced";
import { scrollTransition } from "./utils/scroll-transition";
import type { WithNormalizedProps } from "../../global";
import { useReducedMotion } from "../../common/dom";
import { useReducedMotion } from "../../common/dom";

type Direction = typeof LEFT | typeof RIGHT;
// Used for carousel slide direction.
Expand Down Expand Up @@ -519,7 +519,7 @@ class Carousel extends Marko.Component<Input, State> {
this.skipScrolling = false;

// If user had reduced motion turned on in OS settings, pause autoplay.
if(useReducedMotion) {
if (useReducedMotion) {
this.state.paused = true;
}

Expand Down
2 changes: 1 addition & 1 deletion src/components/ebay-chip/chip.stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export default {
export const Default = Template.bind({});
Default.args = {
renderBody: "chip text" as any,
} ;
};
Default.parameters = {
docs: {
source: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import DefaultCode from "./examples/default.marko?raw";
import SelectedTemplate from "./examples/selected.marko";
import SelectedCode from "./examples/selected.marko?raw";


export default {
title: "form input/ebay-chips-combobox",
component: Combobox,
Expand Down
9 changes: 5 additions & 4 deletions src/components/ebay-combobox/component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,11 @@ interface ComboboxInput extends Omit<Marko.Input<"input">, `on${string}`> {
"list-selection"?: "manual" | "automatic";
"floating-label"?: boolean;
"view-all-options"?: boolean;
button?: Marko.Input<"button"> & Marko.AttrTag<{
htmlAttributes?: Record<string, unknown>;
renderBody?: Marko.Body;
}>;
button?: Marko.Input<"button"> &
Marko.AttrTag<{
htmlAttributes?: Record<string, unknown>;
renderBody?: Marko.Body;
}>;
options?: Marko.AttrTag<ComboboxOption>;
"chevron-size"?: "large";
"on-focus"?: (event: ComboboxEvent) => void;
Expand Down
2 changes: 1 addition & 1 deletion src/components/ebay-cta-button/cta-button.stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import Cta, { type Input } from "./index.marko";
const Template: Story<Input> = (args) => ({
input: {
...args,
renderBody: function(out: any) {
renderBody: function (out: any) {
out.html(args.renderBody);
} as any,
},
Expand Down
5 changes: 3 additions & 2 deletions src/components/ebay-details/details.stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import type { Input } from "./component-browser";
const Template: Story<Input> = (args) => ({
input: {
...args,
renderBody: function(out: any) {
renderBody: function (out: any) {
out.html(args.renderBody);
} as any,
},
Expand Down Expand Up @@ -88,7 +88,8 @@ export default {

export const Standard = Template.bind({});
Standard.args = {
renderBody: `Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.` as any,
renderBody:
`Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.` as any,
text: "Show me the details!",
size: "regular",
open: false,
Expand Down
2 changes: 1 addition & 1 deletion src/components/ebay-fake-link/fake-link.stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import type { Input } from "./component-browser";
const Template: Story<Input> = (args) => ({
input: {
...args,
renderBody: function(out: any) {
renderBody: function (out: any) {
out.html(args.renderBody);
} as any,
},
Expand Down
18 changes: 18 additions & 0 deletions src/components/ebay-icon/examples/all.marko
Original file line number Diff line number Diff line change
Expand Up @@ -690,6 +690,24 @@ div.icon-examples
span.text
-- ebay-cb-32-colored-icon

div
span.icon
ebay-ccd-charger-included-icon
span.text
-- ebay-ccd-charger-included-icon

div
span.icon
ebay-ccd-charger-not-included-icon
span.text
-- ebay-ccd-charger-not-included-icon

div
span.icon
ebay-ccd-top-icon
span.text
-- ebay-ccd-top-icon

div
span.icon
ebay-certified-recycled-16-icon
Expand Down
2 changes: 1 addition & 1 deletion src/components/ebay-switch/switch.stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export default {
},
},
},
} ;
};

export const WithLabel: Story<Input> = (args) => ({
input: args,
Expand Down
2 changes: 1 addition & 1 deletion src/components/ebay-table/table.stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export default {
},
},
},
} ;
};

export const Default = buildExtensionTemplate(defaultTemplate, defaultCode);
export const TableDensity = buildExtensionTemplate(
Expand Down

0 comments on commit f49da92

Please sign in to comment.