[Embeddables Rebuild] Move legacy viusalize embeddable to legacy/embe…

…ddable (elastic#192002)

## Summary

In visualize, renames the new `react_embeddable` folder to just
`embeddable`, and moves the previous `embeddable` folder to
`legacy/embeddable`.

Keeps a few constants and interfaces that are reused in the new
embeddable in the `embeddable` folder, and imports them into
`legacy/embeddable` where needed.

---------

Co-authored-by: Marco Liberati <[email protected]>

examples/portable_dashboards_example/public/dynamically_add_panels_example.tsx

@@ -23,7 +23,7 @@ import {
   VisualizeEmbeddable,
   VisualizeInput,
   VisualizeOutput,
-} from '@kbn/visualizations-plugin/public/embeddable/visualize_embeddable';
+} from '@kbn/visualizations-plugin/public/legacy/embeddable/visualize_embeddable';
 
 const INPUT_KEY = 'portableDashboard:saveExample:input';
 

src/plugins/visualizations/public/actions/edit_in_lens_action.tsx

@@ -26,7 +26,7 @@ import {
 import { Action } from '@kbn/ui-actions-plugin/public';
 import React from 'react';
 import { take } from 'rxjs';
-import { apiHasVisualizeConfig, HasVisualizeConfig } from '../embeddable';
+import { apiHasVisualizeConfig, HasVisualizeConfig } from '../legacy/embeddable';
 import {
   apiHasExpressionVariables,
   HasExpressionVariables,

src/plugins/visualizations/public/react_embeddable/get_expression_renderer_props.ts → src/plugins/visualizations/public/embeddable/get_expression_renderer_props.ts

@@ -10,7 +10,7 @@
 import type { KibanaExecutionContext } from '@kbn/core-execution-context-common';
 import { AggregateQuery, Filter, Query, TimeRange } from '@kbn/es-query';
 import { ExpressionRendererEvent, ExpressionRendererParams } from '@kbn/expressions-plugin/public';
-import { toExpressionAst } from '../embeddable/to_ast';
+import { toExpressionAst } from './to_ast';
 import { getExecutionContext, getTimeFilter } from '../services';
 import type { VisParams } from '../types';
 import type { Vis } from '../vis';

src/plugins/visualizations/public/react_embeddable/index.ts → src/plugins/visualizations/public/embeddable/get_visualize_embeddable_factory_lazy.ts

@@ -7,4 +7,7 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-export { getVisualizeEmbeddableFactory } from './visualize_embeddable';
+export const getVisualizeEmbeddableFactoryLazy = async () => {
+  const { getVisualizeEmbeddableFactory } = await import('./visualize_embeddable');
+  return getVisualizeEmbeddableFactory;
+};

src/plugins/visualizations/public/embeddable/index.ts

@@ -7,11 +7,5 @@
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
 
-export { VisualizeEmbeddableFactory } from './visualize_embeddable_factory';
-export { VISUALIZE_EMBEDDABLE_TYPE, COMMON_VISUALIZATION_GROUPING } from './constants';
+export { getVisualizeEmbeddableFactoryLazy } from './get_visualize_embeddable_factory_lazy';
 export { VIS_EVENT_TO_TRIGGER } from './events';
-export { createVisEmbeddableFromObject } from './create_vis_embeddable_from_object';
-
-export type { VisualizeEmbeddable, VisualizeInput } from './visualize_embeddable';
-
-export { type HasVisualizeConfig, apiHasVisualizeConfig } from './interfaces/has_visualize_config';

src/plugins/visualizations/public/react_embeddable/types.ts → src/plugins/visualizations/public/embeddable/types.ts

@@ -22,7 +22,7 @@ import {
   SerializedTitles,
 } from '@kbn/presentation-publishing';
 import { DeepPartial } from '@kbn/utility-types';
-import { HasVisualizeConfig } from '../embeddable';
+import { HasVisualizeConfig } from '../legacy/embeddable';
 import type { Vis, VisParams, VisSavedObject } from '../types';
 import type { SerializedVis } from '../vis';