[SecuritySolution][Onboarding] Siem migration start card and flyout -…

… Part 1 (elastic#202886) ## Summary Part of: elastic/security-team#10667 Implementation of the Onboarding card to create migrations using the flyout > [!NOTE] > This feature needs `siemMigrationsEnabled` experimental flag enabled to work. Otherwise only the default topic will be available and the topic selector won't be displayed. <img width="1547" alt="image" src="https://github.com/user-attachments/assets/f43c60a0-0631-44d8-ba82-7f16971ecc24"> #### To do in part 2: - Complete implementation of migration finished panel: chart and stats - Improve implementation of migration ready panel: should only allow open the flyout - Implement missing steps in the flyout: Macros and Lookups ### Test Enable experimental flag Use file: [1733135547_1420.json](https://github.com/user-attachments/files/18010116/1733135547_1420.json) --------- Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: kibanamachine <[email protected]>
e40pud · Dec 5, 2024 · b5c1194 · b5c1194
1 parent 5c6c4f4
commit b5c1194
Show file tree

Hide file tree

Showing 66 changed files with 2,194 additions and 387 deletions.
diff --git a/x-pack/plugins/security_solution/common/api/quickstart_client.gen.ts b/x-pack/plugins/security_solution/common/api/quickstart_client.gen.ts
@@ -356,6 +356,7 @@ import type {
   ResolveTimelineResponse,
 } from './timeline/resolve_timeline/resolve_timeline_route.gen';
 import type {
+  CreateRuleMigrationRequestParamsInput,
   CreateRuleMigrationRequestBodyInput,
   CreateRuleMigrationResponse,
   GetAllStatsRuleMigrationResponse,
@@ -686,7 +687,7 @@ If a record already exists for the specified entity, that record is overwritten
     this.log.info(`${new Date().toISOString()} Calling API CreateRuleMigration`);
     return this.kbnClient
       .request<CreateRuleMigrationResponse>({
-        path: '/internal/siem_migrations/rules',
+        path: replaceParams('/internal/siem_migrations/rules/{migration_id}', props.params),
         headers: {
           [ELASTIC_HTTP_VERSION_HEADER]: '1',
         },
@@ -2267,6 +2268,7 @@ export interface CreateRuleProps {
   body: CreateRuleRequestBodyInput;
 }
 export interface CreateRuleMigrationProps {
+  params: CreateRuleMigrationRequestParamsInput;
   body: CreateRuleMigrationRequestBodyInput;
 }
 export interface CreateTimelinesProps {

diff --git a/x-pack/plugins/security_solution/common/siem_migrations/constants.ts b/x-pack/plugins/security_solution/common/siem_migrations/constants.ts
@@ -11,6 +11,8 @@ export const SIEM_MIGRATIONS_PATH = '/internal/siem_migrations' as const;
 export const SIEM_RULE_MIGRATIONS_PATH = `${SIEM_MIGRATIONS_PATH}/rules` as const;
 
 export const SIEM_RULE_MIGRATIONS_ALL_STATS_PATH = `${SIEM_RULE_MIGRATIONS_PATH}/stats` as const;
+export const SIEM_RULE_MIGRATION_CREATE_PATH =
+  `${SIEM_RULE_MIGRATIONS_PATH}/{migration_id?}` as const;
 export const SIEM_RULE_MIGRATION_PATH = `${SIEM_RULE_MIGRATIONS_PATH}/{migration_id}` as const;
 export const SIEM_RULE_MIGRATION_START_PATH = `${SIEM_RULE_MIGRATION_PATH}/start` as const;
 export const SIEM_RULE_MIGRATION_RETRY_PATH = `${SIEM_RULE_MIGRATION_PATH}/retry` as const;

diff --git a/...ck/plugins/security_solution/common/siem_migrations/model/api/rules/rule_migration.gen.ts b/...ck/plugins/security_solution/common/siem_migrations/model/api/rules/rule_migration.gen.ts
@@ -17,19 +17,28 @@
 import { z } from '@kbn/zod';
 import { ArrayFromString } from '@kbn/zod-helpers';
 
+import { NonEmptyString } from '../../../../api/model/primitives.gen';
 import {
-  OriginalRule,
   ElasticRulePartial,
   RuleMigrationTranslationResult,
   RuleMigrationComments,
   RuleMigrationTaskStats,
+  OriginalRule,
   RuleMigration,
   RuleMigrationTranslationStats,
   RuleMigrationResourceData,
   RuleMigrationResourceType,
   RuleMigrationResource,
 } from '../../rule_migration.gen';
-import { NonEmptyString, ConnectorId, LangSmithOptions } from '../../common.gen';
+import { ConnectorId, LangSmithOptions } from '../../common.gen';
+
+export type CreateRuleMigrationRequestParams = z.infer<typeof CreateRuleMigrationRequestParams>;
+export const CreateRuleMigrationRequestParams = z.object({
+  migration_id: NonEmptyString.optional(),
+});
+export type CreateRuleMigrationRequestParamsInput = z.input<
+  typeof CreateRuleMigrationRequestParams
+>;
 
 export type CreateRuleMigrationRequestBody = z.infer<typeof CreateRuleMigrationRequestBody>;
 export const CreateRuleMigrationRequestBody = z.array(OriginalRule);

diff --git a/...ugins/security_solution/common/siem_migrations/model/api/rules/rule_migration.schema.yaml b/...ugins/security_solution/common/siem_migrations/model/api/rules/rule_migration.schema.yaml
@@ -4,38 +4,7 @@ info:
   version: '1'
 paths:
   # Rule migrations APIs
-
   /internal/siem_migrations/rules:
-    post:
-      summary: Creates a new rule migration
-      operationId: CreateRuleMigration
-      x-codegen-enabled: true
-      x-internal: true
-      description: Creates a new SIEM rules migration using the original vendor rules provided
-      tags:
-        - SIEM Rule Migrations
-      requestBody:
-        required: true
-        content:
-          application/json:
-            schema:
-              type: array
-              items:
-                $ref: '../../rule_migration.schema.yaml#/components/schemas/OriginalRule'
-      responses:
-        200:
-          description: Indicates migration have been created correctly.
-          content:
-            application/json:
-              schema:
-                type: object
-                required:
-                  - migration_id
-                properties:
-                  migration_id:
-                    description: The migration id created.
-                    $ref: '../../common.schema.yaml#/components/schemas/NonEmptyString'
-
     put:
       summary: Updates rules migrations
       operationId: UpdateRuleMigration
@@ -57,7 +26,7 @@ paths:
                 properties:
                   id:
                     description: The rule migration id
-                    $ref: '../../common.schema.yaml#/components/schemas/NonEmptyString'
+                    $ref: '../../../../../common/api/model/primitives.schema.yaml#/components/schemas/NonEmptyString'
                   elastic_rule:
                     description: The migrated elastic rule attributes to update.
                     $ref: '../../rule_migration.schema.yaml#/components/schemas/ElasticRulePartial'
@@ -81,95 +50,64 @@ paths:
                     type: boolean
                     description: Indicates rules migrations have been updated.
 
-  /internal/siem_migrations/rules/{migration_id}/install:
-    post:
-      summary: Installs translated migration rules
-      operationId: InstallMigrationRules
+  /internal/siem_migrations/rules/stats:
+    get:
+      summary: Retrieves the stats for all rule migrations
+      operationId: GetAllStatsRuleMigration
       x-codegen-enabled: true
-      description: Installs migration rules
+      x-internal: true
+      description: Retrieves the rule migrations stats for all migrations stored in the system
       tags:
         - SIEM Rule Migrations
-      parameters:
-        - name: migration_id
-          in: path
-          required: true
-          schema:
-            description: The migration id to isnstall rules for
-            $ref: '../../common.schema.yaml#/components/schemas/NonEmptyString'
-      requestBody:
-        required: true
-        content:
-          application/json:
-            schema:
-              type: array
-              items:
-                description: The rule migration id
-                $ref: '../../common.schema.yaml#/components/schemas/NonEmptyString'
       responses:
         200:
-          description: Indicates rules migrations have been installed correctly.
+          description: Indicates rule migrations have been retrieved correctly.
           content:
             application/json:
               schema:
-                type: object
-                required:
-                  - installed
-                properties:
-                  installed:
-                    type: boolean
-                    description: Indicates rules migrations have been installed.
+                type: array
+                items:
+                  $ref: '../../rule_migration.schema.yaml#/components/schemas/RuleMigrationTaskStats'
 
-  /internal/siem_migrations/rules/{migration_id}/install_translated:
+  ## Specific rule migration APIs
+
+  /internal/siem_migrations/rules/{migration_id}:
     post:
-      summary: Installs all translated migration rules
-      operationId: InstallTranslatedMigrationRules
+      summary: Creates a new rule migration
+      operationId: CreateRuleMigration
       x-codegen-enabled: true
-      description: Installs all translated migration rules
+      x-internal: true
+      description: Creates a new SIEM rules migration using the original vendor rules provided
       tags:
         - SIEM Rule Migrations
       parameters:
         - name: migration_id
           in: path
-          required: true
+          required: false
           schema:
-            description: The migration id to install translated rules for
-            $ref: '../../common.schema.yaml#/components/schemas/NonEmptyString'
+            description: The migration id to create rules for
+            $ref: '../../../../../common/api/model/primitives.schema.yaml#/components/schemas/NonEmptyString'
+      requestBody:
+        required: true
+        content:
+          application/json:
+            schema:
+              type: array
+              items:
+                $ref: '../../rule_migration.schema.yaml#/components/schemas/OriginalRule'
       responses:
         200:
-          description: Indicates rules migrations have been installed correctly.
+          description: Indicates migration have been created correctly.
           content:
             application/json:
               schema:
                 type: object
                 required:
-                  - installed
+                  - migration_id
                 properties:
-                  installed:
-                    type: boolean
-                    description: Indicates rules migrations have been installed.
-
-  /internal/siem_migrations/rules/stats:
-    get:
-      summary: Retrieves the stats for all rule migrations
-      operationId: GetAllStatsRuleMigration
-      x-codegen-enabled: true
-      x-internal: true
-      description: Retrieves the rule migrations stats for all migrations stored in the system
-      tags:
-        - SIEM Rule Migrations
-      responses:
-        200:
-          description: Indicates rule migrations have been retrieved correctly.
-          content:
-            application/json:
-              schema:
-                type: array
-                items:
-                  $ref: '../../rule_migration.schema.yaml#/components/schemas/RuleMigrationTaskStats'
-
-  ## Specific rule migration APIs
-
-  /internal/siem_migrations/rules/{migration_id}:
+                  migration_id:
+                    description: The migration id created.
+                    $ref: '../../../../../common/api/model/primitives.schema.yaml#/components/schemas/NonEmptyString'
     get:
       summary: Retrieves all the rules of a migration
       operationId: GetRuleMigration
@@ -184,7 +122,7 @@ paths:
           required: true
           schema:
             description: The migration id to start
-            $ref: '../../common.schema.yaml#/components/schemas/NonEmptyString'
+            $ref: '../../../../../common/api/model/primitives.schema.yaml#/components/schemas/NonEmptyString'
         - name: page
           in: query
           required: false
@@ -222,6 +160,73 @@ paths:
         204:
           description: Indicates the migration id was not found.
 
+  /internal/siem_migrations/rules/{migration_id}/install:
+    post:
+      summary: Installs translated migration rules
+      operationId: InstallMigrationRules
+      x-codegen-enabled: true
+      description: Installs migration rules
+      tags:
+        - SIEM Rule Migrations
+      parameters:
+        - name: migration_id
+          in: path
+          required: true
+          schema:
+            description: The migration id to install rules for
+            $ref: '../../../../../common/api/model/primitives.schema.yaml#/components/schemas/NonEmptyString'
+      requestBody:
+        required: true
+        content:
+          application/json:
+            schema:
+              type: array
+              items:
+                description: The rule migration id
+                $ref: '../../../../../common/api/model/primitives.schema.yaml#/components/schemas/NonEmptyString'
+      responses:
+        200:
+          description: Indicates rules migrations have been installed correctly.
+          content:
+            application/json:
+              schema:
+                type: object
+                required:
+                  - installed
+                properties:
+                  installed:
+                    type: boolean
+                    description: Indicates rules migrations have been installed.
+
+  /internal/siem_migrations/rules/{migration_id}/install_translated:
+    post:
+      summary: Installs all translated migration rules
+      operationId: InstallTranslatedMigrationRules
+      x-codegen-enabled: true
+      description: Installs all translated migration rules
+      tags:
+        - SIEM Rule Migrations
+      parameters:
+        - name: migration_id
+          in: path
+          required: true
+          schema:
+            description: The migration id to install translated rules for
+            $ref: '../../../../../common/api/model/primitives.schema.yaml#/components/schemas/NonEmptyString'
+      responses:
+        200:
+          description: Indicates rules migrations have been installed correctly.
+          content:
+            application/json:
+              schema:
+                type: object
+                required:
+                  - installed
+                properties:
+                  installed:
+                    type: boolean
+                    description: Indicates rules migrations have been installed.
+
   /internal/siem_migrations/rules/{migration_id}/start:
     put:
       summary: Starts a rule migration
@@ -237,7 +242,7 @@ paths:
           required: true
           schema:
             description: The migration id to start
-            $ref: '../../common.schema.yaml#/components/schemas/NonEmptyString'
+            $ref: '../../../../../common/api/model/primitives.schema.yaml#/components/schemas/NonEmptyString'
       requestBody:
         required: true
         content:
@@ -282,7 +287,7 @@ paths:
           required: true
           schema:
             description: The migration id to fetch stats for
-            $ref: '../../common.schema.yaml#/components/schemas/NonEmptyString'
+            $ref: '../../../../../common/api/model/primitives.schema.yaml#/components/schemas/NonEmptyString'
       responses:
         200:
           description: Indicates the migration stats has been retrieved correctly.
@@ -307,7 +312,7 @@ paths:
           required: true
           schema:
             description: The migration id to fetch translation stats for
-            $ref: '../../common.schema.yaml#/components/schemas/NonEmptyString'
+            $ref: '../../../../../common/api/model/primitives.schema.yaml#/components/schemas/NonEmptyString'
       responses:
         200:
           description: Indicates the migration stats has been retrieved correctly.
@@ -333,7 +338,7 @@ paths:
           required: true
           schema:
             description: The migration id to stop
-            $ref: '../../common.schema.yaml#/components/schemas/NonEmptyString'
+            $ref: '../../../../../common/api/model/primitives.schema.yaml#/components/schemas/NonEmptyString'
       responses:
         200:
           description: Indicates migration task stop has been processed successfully.
@@ -368,7 +373,7 @@ paths:
           required: true
           schema:
             description: The migration id to attach the resources
-            $ref: '../../common.schema.yaml#/components/schemas/NonEmptyString'
+            $ref: '../../../../../common/api/model/primitives.schema.yaml#/components/schemas/NonEmptyString'
       requestBody:
         required: true
         content:
@@ -406,7 +411,7 @@ paths:
           required: true
           schema:
             description: The migration id to attach the resources
-            $ref: '../../common.schema.yaml#/components/schemas/NonEmptyString'
+            $ref: '../../../../../common/api/model/primitives.schema.yaml#/components/schemas/NonEmptyString'
         - name: type
           in: query
           required: false

diff --git a/x-pack/plugins/security_solution/common/siem_migrations/model/common.gen.ts b/x-pack/plugins/security_solution/common/siem_migrations/model/common.gen.ts
@@ -16,15 +16,6 @@
 
 import { z } from '@kbn/zod';
 
-/**
- * A string that is not empty and does not contain only whitespace
- */
-export type NonEmptyString = z.infer<typeof NonEmptyString>;
-export const NonEmptyString = z
-  .string()
-  .min(1)
-  .regex(/^(?! *$).+$/);
-
 /**
  * The GenAI connector id to use.
  */