Skip to content

Commit

Permalink
[Lens] fix flaky test with deleting filters (elastic#191316)
Browse files Browse the repository at this point in the history
## Summary

Fixes elastic#191009

(also fixes elastic#189569
elastic#178270
elastic#139040 which are already closed
as one time occurances but could happen again)

https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6809
  • Loading branch information
mbondyra authored Aug 27, 2024
1 parent b386e1c commit b5570ec
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions test/functional/services/filter_bar.ts
Original file line number Diff line number Diff line change
Expand Up @@ -133,10 +133,11 @@ export class FilterBarService extends FtrService {
* @param key field name
*/
public async removeFilter(key: string): Promise<void> {
await this.retry.try(async () => {
await this.retry.waitFor('filter pill context menu is open', async () => {
await this.testSubjects.click(`~filter & ~filter-key-${key}`);
await this.testSubjects.click(`deleteFilter`);
return await this.testSubjects.exists('deleteFilter');
});
await this.testSubjects.click(`deleteFilter`);
await this.header.awaitGlobalLoadingIndicatorHidden();
}

Expand Down

0 comments on commit b5570ec

Please sign in to comment.