made list of liquids and gases global in fluids.py #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #571 +/- ##
========================================
Coverage 85.01% 85.02%
========================================
Files 90 90
Lines 6200 6203 +3
========================================
+ Hits 5271 5274 +3
Misses 929 929 ☔ View full report in Codecov by Sentry. |
- adapted wrong files for new biomethane properties - added lhv and hhv with exception in case file was not found, as these properties are not absolutely necessary
|
@kbensafta could you provide a lhv for the new biomethane properties? You can just write them here, I could add them. |
SimonRubenDrauz
approved these changes
Nov 17, 2023
SimonRubenDrauz
previously approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A first step towards an applicable fluid library, if needed. Anyone from outside at least can get a better overview of the implemented fluids in pandapipes.