feat: fix pr review, #361

e2e-test-quest · Dec 12, 2023 · 3aaf14a · 3aaf14a
1 parent bf323dd
commit 3aaf14a
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 16 deletions.
diff --git a/...docs/i18n/fr/docusaurus-plugin-content-docs/current/05-migration/01-v1-to-v2.md b/...docs/i18n/fr/docusaurus-plugin-content-docs/current/05-migration/01-v1-to-v2.md
@@ -2,5 +2,5 @@
 
 ## Corriger les majuscules abusives
 - Remplacer toutes les occurences de `Within` par `within` dans tous vos fichiers **.feature**.
-- Dans vos scénarios, veuillez à utiliser les bons articles définis et indéfinis, ainsi qu'à bien accorder les adjectifs avec les mots parce que la nouvelle version est plus stricte sur la structure des phrases
+- Dans vos scénarios, veillez à utiliser les bons articles définis et indéfinis, ainsi qu'à bien accorder les adjectifs avec les mots parce que la nouvelle version est plus stricte sur la structure des phrases
 
diff --git a/packages/runner-commons/src/assets/i18n/web/en/en-roles.ts b/packages/runner-commons/src/assets/i18n/web/en/en-roles.ts
@@ -53,10 +53,10 @@ class EnAccessibleRole extends AccessibleRole {
 }
 
 export const EN_ROLES: AccessibleRole[] = [
-    { id: "alert", name: "alert", definiteArticle: DEFINITE_ARTICLE.THE, indefiniteArticle: INDEFINITE_ARTICLE.AN },
-    { id: "alertdialog", name: "alert dialog", definiteArticle: DEFINITE_ARTICLE.THE, indefiniteArticle: INDEFINITE_ARTICLE.AN },
-    { id: "application", name: "application", definiteArticle: DEFINITE_ARTICLE.THE, indefiniteArticle: INDEFINITE_ARTICLE.AN },
-    { id: "article", name: "article", definiteArticle: DEFINITE_ARTICLE.THE, indefiniteArticle: INDEFINITE_ARTICLE.AN },
+    { id: "alert", name: "alert", indefiniteArticle: INDEFINITE_ARTICLE.AN },
+    { id: "alertdialog", name: "alert dialog", indefiniteArticle: INDEFINITE_ARTICLE.AN },
+    { id: "application", name: "application", indefiniteArticle: INDEFINITE_ARTICLE.AN },
+    { id: "article", name: "article", indefiniteArticle: INDEFINITE_ARTICLE.AN },
     { id: "banner", name: "banner" },
     { id: "button", name: "button" },
     { id: "cell", name: "cell" },
@@ -81,7 +81,7 @@ export const EN_ROLES: AccessibleRole[] = [
     { id: "group", name: "group" },
     { id: "heading", name: "title" },
     { id: "img", name: "picture" },
-    { id: "input", name: "entry", definiteArticle: DEFINITE_ARTICLE.THE, indefiniteArticle: INDEFINITE_ARTICLE.AN },
+    { id: "input", name: "entry", indefiniteArticle: INDEFINITE_ARTICLE.AN },
     { id: "landmark", name: "landmark" },
     { id: "link", name: "link" },
     { id: "list", name: "list" },
@@ -100,7 +100,7 @@ export const EN_ROLES: AccessibleRole[] = [
     { id: "navigation", name: "navigation" },
     { id: "none", name: "no" },
     { id: "note", name: "note" },
-    { id: "option", name: "option" },
+    { id: "option", name: "option", indefiniteArticle: INDEFINITE_ARTICLE.AN },
     { id: "presentation", name: "presentation" },
     { id: "progressbar", name: "progress bar" },
     { id: "radio", name: "radio" },

diff --git a/packages/runner-commons/src/assets/i18n/web/fr/fr-roles.ts b/packages/runner-commons/src/assets/i18n/web/fr/fr-roles.ts
@@ -135,9 +135,9 @@ export const FR_ROLES: AccessibleRole[] = [
     },
     {
         id: "contentinfo",
-        name: "contentinfo",
-        definiteArticle: FR_DEFINITE_ARTICLE.LE,
-        indefiniteArticle: FR_INDEFINITE_ARTICLE.UN
+        name: "information de contenu",
+        definiteArticle: FR_DEFINITE_ARTICLE.L,
+        indefiniteArticle: FR_INDEFINITE_ARTICLE.UNE
     },
     {
         id: "definition",
@@ -429,7 +429,7 @@ export const FR_ROLES: AccessibleRole[] = [
     },
     {
         id: "select",
-        name: "sélectionner",
+        name: "sélecteur",
         definiteArticle: FR_DEFINITE_ARTICLE.LE,
         indefiniteArticle: FR_INDEFINITE_ARTICLE.UN
     },
@@ -484,18 +484,18 @@ export const FR_ROLES: AccessibleRole[] = [
     {
         id: "table",
         name: "tableau",
-        definiteArticle: FR_DEFINITE_ARTICLE.LA,
+        definiteArticle: FR_DEFINITE_ARTICLE.LE,
         indefiniteArticle: FR_INDEFINITE_ARTICLE.UNE
     },
     {
         id: "tablist",
-        name: "tablist",
+        name: "liste d'onglet",
         definiteArticle: FR_DEFINITE_ARTICLE.LA,
         indefiniteArticle: FR_INDEFINITE_ARTICLE.UNE
     },
     {
         id: "tabpanel",
-        name: "tabpanel",
+        name: "panneau d'onglet",
         definiteArticle: FR_DEFINITE_ARTICLE.LE,
         indefiniteArticle: FR_INDEFINITE_ARTICLE.UN
     },

diff --git a/...s/runner-commons/src/step-definition-generator/generate-step-definitions-documentation.ts b/...s/runner-commons/src/step-definition-generator/generate-step-definitions-documentation.ts
@@ -34,8 +34,8 @@ export function runGenerateDoc(destDir: string) {
             useGrouping: false,
         });
         const generatedFile = `${GENERATED_DIR_DOC}/${indexOfFile}-${lang}-generated-wording-description.md`;
-        const wordingBaseFile = path.join(__dirname, `/../assets/i18n/web/${lang}/${lang}.json`);
-        const wordingEnrichedFile = path.join(__dirname, `/../assets/i18n/web/${lang}/${lang}-enriched-wordings.json`);
+        const wordingBaseFile = path.join(__dirname, `../assets/i18n/web/${lang}/${lang}.json`);
+        const wordingEnrichedFile = path.join(__dirname, `../assets/i18n/web/${lang}/${lang}-enriched-wordings.json`);
         const autocompletionSuggestionFile = path.join(GENERATED_DIR_DOC, `${lang}-autocompletion-suggestion.json`);
         cleanGeneratedFilesIfExists(generatedFile, lang, indexOfFile);
         Common.cleanGeneratedFilesIfExists(autocompletionSuggestionFile);