news shortcodes moved to plugin

[Jimmi08]

Motivation and Context

](https://github.com//issues/5065)

Description

just moved the shortcode file and changed way how they are called

How Has This Been Tested?

Real example

Types of Changes

• Bug fix (non-breaking change which fixes an issue)
• [ x] New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• [x ] Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation (a change to man pages or other documentation)

Checklist

• [ x] My code adheres to the e107 code style standard.
• [ x] I have read the contributing document.
• I have added tests to cover my changes.
• All new and existing tests pass.

[CaMer0n]

@Jimmi08 I understand the motivation, but this is a breaking change. Every theme or plugin in existence which either calls the shortcodes via e107::getScBatch(), or loads them the old way with a require_once(e_CORE."shortcodes/batch/news_shortcodes.php"); would cease to function correctly. So, at the very least, a placeholder file would need to be left at e_CORE."shortcodes/batch/news_shortcodes.php.

[Jimmi08]

In public static function getScBatch($className, $pluginName = null, $overrideClass = null)

/* legacy fix */ 
if($className == "news") $pluginName = true;

and add debug warning about using outdated code.

Nevermind, you can close this. I finished separating news from the core (including URLs) so I am too forward to need this anymore.