Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#169 - ability to edit and delete opinions for administrator #201

Merged
merged 18 commits into from
Apr 8, 2024
Merged

#169 - ability to edit and delete opinions for administrator #201

merged 18 commits into from
Apr 8, 2024

Conversation

Lee0z
Copy link
Collaborator

@Lee0z Lee0z commented Jan 12, 2024

This should close #169.

@Lee0z Lee0z requested a review from a team as a code owner January 12, 2024 16:05
@Lee0z
Copy link
Collaborator Author

Lee0z commented Jan 12, 2024

Admin has now ability to edit and delete every opinion.

  • Logged as user:
image
  • Logged as admin:
image

AleksandraKozubal
AleksandraKozubal reviewed Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@AleksandraKozubal AleksandraKozubal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admin should not be able to edit anyone's comment except their own

@zmigrOO
Copy link
Collaborator

zmigrOO commented Jan 12, 2024

After commit:
image

AleksandraKozubal
AleksandraKozubal reviewed Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@AleksandraKozubal AleksandraKozubal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove comments

@zmigrOO zmigrOO added the priority first thing to do label Jan 15, 2024
kamilpiech97
kamilpiech97 suggested changes Jan 15, 2024
View reviewed changes
app/Http/Controllers/CityOpinionController.php Outdated Show resolved Hide resolved
app/Http/Controllers/CityOpinionController.php Outdated Show resolved Hide resolved
@AleksandraKozubal AleksandraKozubal removed the priority first thing to do label Mar 7, 2024
@Lee0z Lee0z requested a review from kamilpiech97 March 11, 2024 18:13
@AleksandraKozubal AleksandraKozubal requested a review from vojcc March 15, 2024 10:24
kamilpiech97
kamilpiech97 suggested changes Mar 18, 2024
View reviewed changes
app/Http/Controllers/CityOpinionController.php Outdated Show resolved Hide resolved
app/Http/Controllers/CityOpinionController.php Outdated Show resolved Hide resolved
app/Http/Controllers/CityOpinionController.php Outdated Show resolved Hide resolved
app/Policies/CityOpinionPolicy.php Outdated Show resolved Hide resolved
kamilpiech97
kamilpiech97 suggested changes Apr 2, 2024
View reviewed changes
app/Http/Controllers/CityOpinionController.php Outdated Show resolved Hide resolved
app/Http/Controllers/CityOpinionController.php Outdated Show resolved Hide resolved
@EwelinaSkrzypacz
Copy link
Contributor

EwelinaSkrzypacz commented Apr 8, 2024 •
edited
Loading

Conflicts :(

@Lee0z
Copy link
Collaborator Author

Lee0z commented Apr 8, 2024

Conflicts resolved

@Lee0z Lee0z merged commit 39e2e60 into main Apr 8, 2024
3 checks passed
@Lee0z Lee0z deleted the #169-Ability-to-edit-and-delete-opinions-for-administrator branch April 8, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakubKermes JakubKermes JakubKermes left review comments

@AleksandraKozubal AleksandraKozubal AleksandraKozubal approved these changes

@zmigrOO zmigrOO zmigrOO approved these changes

@EwelinaSkrzypacz EwelinaSkrzypacz EwelinaSkrzypacz approved these changes

@kamilpiech97 kamilpiech97 kamilpiech97 approved these changes

@vojcc vojcc Awaiting requested review from vojcc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to edit and delete opinions for administator
7 participants
@Lee0z @zmigrOO @EwelinaSkrzypacz @kamilpiech97 @vojcc @AleksandraKozubal @JakubKermes