#12 - add link to install/open provider's app #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
December 7, 2023 12:17
fixed displaying buttons
zmigrOO
changed the title
|
Preview of working buttons |
There was a problem hiding this comment.
- Funfact - when branch's name has slash, Phpstorm shows it like that
I think that name of branch should be simple, like #12-add-link-to-open-install-providers-app
- I'm not a big fan of this list. Maybe darker buttons (like
bg-blumilk-500) will look better? Or maybe white background? I don't know
There was a problem hiding this comment.
My proposal is to make this window sth like that:
- provider's name color blumilk-500 and enlarge pb to 2px
- buttons text with font-weight-normal and button's color to blumilk-400
- remove blumilk color from window's border
Probably rounding the corners of buttons would also look nicer
You mean to round the corners more? |
added 2 commits
December 23, 2023 11:13
AleksandraKozubal
approved these changes
Jan 4, 2024
vojcc
approved these changes
Jan 8, 2024
EwelinaSkrzypacz
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
>php artisan migrate:fresh --seedis required for this to work.Backend works fine, only frontend is to be approved.
It should close #12