#65 - toggle password visibility

[Lee0z]

Added button to toggle password visibility.

• Invisible:
  

• Visible:
  

Same goes to register form.

• Invisible:
  

• Visible:
  

It should close #65.

[EwelinaSkrzypacz]

I think I will get rid of filed "password confirmation" because now we have toggle to see password, but maybe it's a task for another pr?

[Lee0z]

I think I will get rid of filed "password confirmation" because now we have toggle to see password, but maybe it's a task for another pr?

So the button in registration form doesn't reveal "Confirm Password" field? Just the "Password" one?

[EwelinaSkrzypacz]

I think I will get rid of filed "password confirmation" because now we have toggle to see password, but maybe it's a task for another pr?

So the button in registration form doesn't reveal "Confirm Password" field? Just the "Password" one?

No, I mean that we should delete input "Confirm password". This field is unnecessary due to potential user errors, the inconvenience of entering complex passwords twice, the availability of more advanced verification methods, and the desire for a smoother user experience.

[Lee0z]

I think I will get rid of filed "password confirmation" because now we have toggle to see password, but maybe it's a task for another pr?

So the button in registration form doesn't reveal "Confirm Password" field? Just the "Password" one?

No, I mean that we should delete input "Confirm password". This field is unnecessary due to potential user errors, the inconvenience of entering complex passwords twice, the availability of more advanced verification methods, and the desire for a smoother user experience.

That is great idea, so I changed registration form:

Is there any backend code to support that password confirmation? As far as I know it is only frontend feature. Please check commit after this comment.

[EwelinaSkrzypacz]

I think I will get rid of filed "password confirmation" because now we have toggle to see password, but maybe it's a task for another pr?

So the button in registration form doesn't reveal "Confirm Password" field? Just the "Password" one?

No, I mean that we should delete input "Confirm password". This field is unnecessary due to potential user errors, the inconvenience of entering complex passwords twice, the availability of more advanced verification methods, and the desire for a smoother user experience.

That is great idea, so I changed registration form:

Is there any backend code to support that password confirmation? As far as I know it is only frontend feature. Please check commit after this comment.

In files there are some use of password_confirmation, for example

• Feature/SignupTest.php
• Exceptions/ExceptionHandler.php
• Http/Middleware/TrimStrings.php

I will recommend use Ctrl + Shift + F in Phpstorm to search all of occurrences of text

[Lee0z]

I think I will get rid of filed "password confirmation" because now we have toggle to see password, but maybe it's a task for another pr?

So the button in registration form doesn't reveal "Confirm Password" field? Just the "Password" one?

No, I mean that we should delete input "Confirm password". This field is unnecessary due to potential user errors, the inconvenience of entering complex passwords twice, the availability of more advanced verification methods, and the desire for a smoother user experience.

That is great idea, so I changed registration form:
Is there any backend code to support that password confirmation? As far as I know it is only frontend feature. Please check commit after this comment.

In files there are some use of password_confirmation, for example

• Feature/SignupTest.php
• Exceptions/ExceptionHandler.php
• Http/Middleware/TrimStrings.php

I will recommend use Ctrl + Shift + F in Phpstorm to search all of occurrences of text

There was indeed written tests for signup feature, so I've removed password_confirmation field.
Since we don't need "password_confirmation" to be trimmed through middleware, I've deleted that here too, same goes to exceptions.

In backend register request there were also rules specified, which required "confirmation", deleted.

I've manualy tested account creation few times and after modifications it worked.

Also noticed small bug - on error event (wrong password input etc.) the password visibility button moved down to match both error and password field. It's fixed.