-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#140 - add update and delete opinion features #144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vojcc are you interested in finishing this pr? |
@AleksandraKozubal, someone can take a wheel. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I don't have translated text in delete modal (my application language is Polish):
We can leave this problem for another issue, but please crate one
-
You can translate word
content
inlang/pl/validation.php
in arrayatrributes
. -
Please make issue about managing opinions by administrator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should change DeleteModal's header to something like: "Usunąć miasto (city name)?" And in modal's content: This way, we'll avoid conflicting polish grammar. |
For me it will be okay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it's great 😄
@Lee0z you can merge this pr 😃 |
This should close #140.