Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6 - CRUD for providers #139

Merged
merged 52 commits into from
Mar 8, 2024
Merged

#6 - CRUD for providers #139

merged 52 commits into from
Mar 8, 2024

Conversation

AleksandraKozubal
Copy link
Collaborator

@AleksandraKozubal AleksandraKozubal commented Sep 4, 2023

Admin can see all the providers with its' logo, color and url. Delete is also possible (deleted provider is gone until next seed).
image

Create and edit buttons are done, so I left it as 'disabled' option, for later use.

Creating and editing provider is not so easy to do, coz all the info are seeded - we should rethink and come to the conclusion how exactly create/edit should work. I'm leaving this part for the future.

Because this pr completes only a part of #6, I'm not closing this issue.

@AleksandraKozubal AleksandraKozubal marked this pull request as ready for review January 12, 2024 12:27
@AleksandraKozubal AleksandraKozubal requested a review from a team as a code owner January 12, 2024 12:27
Copy link
Contributor

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. "Delete provider" is not translated

image

  1. Disabled buttons should has no changing color, when the user hovers on them - they should be... disabled

Copy link
Contributor

@EwelinaSkrzypacz EwelinaSkrzypacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Mouse cursor is changes, when I hover on button "Edytuj" - it' shouldn't be like that.

image

  1. I don't like this hover on URL

image

  1. When I click on admin navigation "Statistics" I have 404 error.

app/Http/Controllers/Admin/ProviderController.php Outdated Show resolved Hide resolved
app/Http/Controllers/Admin/ProviderController.php Outdated Show resolved Hide resolved
resources/js/Pages/Providers/Index.vue Outdated Show resolved Hide resolved
resources/js/Pages/Providers/Index.vue Outdated Show resolved Hide resolved
app/Models/Provider.php Show resolved Hide resolved
app/Http/Requests/ProviderRequest.php Outdated Show resolved Hide resolved
app/Http/Controllers/Admin/ProviderController.php Outdated Show resolved Hide resolved
@AleksandraKozubal AleksandraKozubal merged commit e4a5559 into main Mar 8, 2024
3 checks passed
@AleksandraKozubal AleksandraKozubal deleted the #6-CRUD-for-providers branch March 8, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants