Removed backend needs for password_confirmation, bugfix

e-motion-apps · Nov 8, 2023 · 330b6c8 · 330b6c8
1 parent 64c82bb
commit 330b6c8
Show file tree

Hide file tree

Showing 5 changed files with 3 additions and 7 deletions.
diff --git a/app/Exceptions/ExceptionHandler.php b/app/Exceptions/ExceptionHandler.php
@@ -17,7 +17,6 @@ class ExceptionHandler extends Handler
     protected $dontFlash = [
         "current_password",
         "password",
-        "password_confirmation",
     ];
 
     public function register(): void

diff --git a/app/Http/Middleware/TrimStrings.php b/app/Http/Middleware/TrimStrings.php
@@ -16,6 +16,5 @@ class TrimStrings extends Middleware
     protected $except = [
         "current_password",
         "password",
-        "password_confirmation",
     ];
 }
diff --git a/app/Http/Requests/RegisterRequest.php b/app/Http/Requests/RegisterRequest.php
@@ -14,7 +14,7 @@ public function rules(): array
         return [
             "name" => ["required", "string", "max:60"],
             "email" => ["required", "string", "email", "max:255", "unique:users"],
-            "password" => ["required", Password::defaults(), "confirmed"],
+            "password" => ["required", Password::defaults()],
         ];
     }
 }
diff --git a/resources/js/Shared/Layout/Nav.vue b/resources/js/Shared/Layout/Nav.vue
@@ -180,8 +180,8 @@ defineExpose({
               <button type="button" class="absolute bottom-3 right-2 md:bottom-2" @click="togglePasswordVisibility">
                 <component :is="!isPasswordVisible ? EyeIcon : EyeSlashIcon" class="h-6 w-6 text-blumilk-400" />
               </button>
-              <ErrorMessage :message="loginForm.errors.loginError" />
             </div>
+            <ErrorMessage :message="loginForm.errors.loginError" />
             <div class="flex w-full md:w-fit">
               <button type="submit"
                       class="w-full rounded-lg bg-blumilk-500 p-4 font-semibold text-white hover:bg-blumilk-600 md:py-2"
@@ -220,8 +220,8 @@ defineExpose({
               <button type="button" class="absolute bottom-3 right-2 md:bottom-2" @click="togglePasswordVisibility">
                 <component :is="!isPasswordVisible ? EyeIcon : EyeSlashIcon" class="h-6 w-6 text-blumilk-400" />
               </button>
-              <ErrorMessage :message="registerForm.errors.password" />
             </div>
+            <ErrorMessage :message="registerForm.errors.password" />
             <div class="flex w-full md:w-fit">
               <button type="submit"
                       class="w-full rounded-lg bg-blumilk-500 p-4 font-semibold text-white hover:bg-blumilk-600 md:py-2"

diff --git a/tests/Feature/SignupTest.php b/tests/Feature/SignupTest.php
@@ -15,7 +15,6 @@ public function testUserCanSignupWithProperCredentials(): void
             "name" => "Test",
             "email" => "[email protected]",
             "password" => "123456789",
-            "password_confirmation" => "123456789",
         ];
 
         $this->post(uri: "/register", data: $user);
@@ -29,7 +28,6 @@ public function testUserCannotBeCreatedWithInvalidName(): void
             "name" => Str::random(256),
             "email" => "[email protected]",
             "password" => "123456789",
-            "password_confirmation" => "123456789",
         ]);
 
         $response->assertSessionHasErrors(["name"]);