Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that genesis-time is not used for jailing and slashing #148

Merged
merged 2 commits into from
Sep 23, 2021

Conversation

haasted
Copy link
Collaborator

@haasted haasted commented Sep 22, 2021

This is a fix for #19.

Copy link
Contributor

@blewater blewater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find and test.
The test with 61 minutes later still finds val2 jailed.

x/slashing/keeper/abci_test.go Show resolved Hide resolved
x/slashing/keeper/abci_test.go Outdated Show resolved Hide resolved
@blewater blewater self-requested a review September 23, 2021 13:43
Copy link
Contributor

@blewater blewater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job identifying the issue and fixing it.

@haasted haasted merged commit ab1eb9a into develop Sep 23, 2021
@haasted haasted deleted the 19-fix-initial-blocks-slashing branch September 23, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants