Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock React version to ~18.2.0 #1148

Merged
merged 10 commits into from
Apr 28, 2024
Merged

Commits on Apr 26, 2024

  1. lock React version to ~18.2.0

    React 19 and React 18.3 are out (https://react.dev/blog/2024/04/25/react-19-upgrade-guide#react-18-3), but the React Native ecosystem is still on React 18.2.
    We need to lock the versions down until the React Native packages update.
    JGreenlee committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    a335ad3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d43d293 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    379bb76 View commit details
    Browse the repository at this point in the history
  4. 📌 Ensure that we are using the correct version of java

    Before this, we set only the `JAVA_HOME` to pin the java version
    This was working until a couple of days ago, when, even after setting the
    version, the java version was not changed.
    
    This may be due to the location for the java executable changing, so let's try
    to set the PATH as well
    
    Also print out several environment variables to help debug further
    
    Related info:
    e-mission#1148 (comment)
    e-mission#1148 (comment)
    shankari committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    e81adf9 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. Configuration menu
    Copy the full SHA
    2255909 View commit details
    Browse the repository at this point in the history
  2. 📌 Pin the mac version to 13

    To be consistent with
    e-mission#1148 (comment)
    
    Before we fix
    e-mission/e-mission-docs#1060
    shankari committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    b5072f3 View commit details
    Browse the repository at this point in the history
  3. 📌 Pin the mac version to 13

    Consistent with
    e-mission#1148 (comment)
    and
    e-mission@b5072f3 (for iOS)
    shankari committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    0d0b212 View commit details
    Browse the repository at this point in the history
  4. ⏪️ Revert previous attempts to fix the issue

    since pinning to OSX-13 fixed it
    e-mission#1148 (comment)
    shankari committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    02abd93 View commit details
    Browse the repository at this point in the history
  5. 📌 Pin the xcode version again

    Because apparently the default version, even on the OSX 13 runner, is now xcode 15
    e-mission#1148 (comment)
    shankari committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    08dca5a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d188a78 View commit details
    Browse the repository at this point in the history