changes after reivew

dzonidoo · Nov 2, 2023 · 258f4a1 · 258f4a1
1 parent faab52e
commit 258f4a1
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 8 deletions.
diff --git a/e2e/cypress/e2e/wire/wire_action.cy.js b/e2e/cypress/e2e/wire/wire_action.cy.js
@@ -36,14 +36,14 @@ describe('wire - filters', () => {
 
         cy.url().should('include', 'Sydney');
 
-        cy.get(`[data-test-id="wire-item"][data-test-value="${WireItems.item_1._id}"]`).should('exist');
-        cy.get(`[data-test-id="wire-item"][data-test-value="${WireItems.item_2._id}"]`).should('not.exist');
+        WirePage.item(WireItems.item_1._id).should('exist');
+        WirePage.item(WireItems.item_2._id).should('not.exist');
 
         cy.get('[data-test-id="top-search-bar"] form input').clear().type("{enter}");
         cy.url().should('not.include', 'Sydney');
 
-        cy.get(`[data-test-id="wire-item"][data-test-value="${WireItems.item_1._id}"]`).should('exist');
-        cy.get(`[data-test-id="wire-item"][data-test-value="${WireItems.item_2._id}"]`).should('exist');
+        WirePage.item(WireItems.item_1._id).should('exist');
+        WirePage.item(WireItems.item_2._id).should('exist');
 
         /**
             FILTERS
@@ -59,8 +59,8 @@ describe('wire - filters', () => {
 
         cy.url().should('include', `${WireItems.item_1.service[0].name}`);
 
-        cy.get(`[data-test-id="wire-item"][data-test-value="${WireItems.item_1._id}"]`).should('exist');
-        cy.get(`[data-test-id="wire-item"][data-test-value="${WireItems.item_2._id}"]`).should('not.exist');
+        WirePage.item(WireItems.item_1._id).should('exist');
+        WirePage.item(WireItems.item_2._id).should('not.exist');
 
         FilterPanel.button('clear');
 
@@ -70,7 +70,7 @@ describe('wire - filters', () => {
         FilterPanel.selectNowDate();
         FilterPanel.button('search');
 
-        cy.get(`[data-test-id="wire-item"][data-test-value="${WireItems.item_1._id}"]`).should('exist');
-        cy.get(`[data-test-id="wire-item"][data-test-value="${WireItems.item_2._id}"]`).should('not.exist'); 
+        WirePage.item(WireItems.item_1._id).should('exist');
+        WirePage.item(WireItems.item_2._id).should('not.exist'); 
     });
 });
diff --git a/e2e/cypress/support/pages/wire.js b/e2e/cypress/support/pages/wire.js
@@ -7,6 +7,10 @@ class WirePageWrapper {
         this.filterPanel = new FilterPanelContainer();
     }
 
+    item(value) {
+        return cy.get(`[data-test-id="wire-item"][data-test-value="${value}"]`);
+    }
+
     showAdvancedSearchModal() {
         cy.get('[data-test-id="show-advanced-search-panel-btn"]').click();
     }