-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add AzureSQL
source and Prefect tasks
#1043
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adrian-wojcik I think you've mixed up Aselite
stuff with AzureSQL
stuff. Could you pls create separate PRs for each?
@trymzet I did not mixed up. As you can see in viadot 1 Aselite task is using AzureSQL source only. |
@adrian-wojcik ok then can you rename this accordingly? Ie. the tasks should and flows should have the name of the source in them, eg. |
We were discussing it with Rafał and as Aselite is using AzureSQL which inherited from SQLServer, probably good idea is to remove in future this connector and move logic from AzureSQL Source to SQLServer Source, so all aselite deployments would use simply sql_server_to_adls flow. But as for now we believe the name convention can stay as it is, as it is temporary solution. |
|
@trymzet Yes, I see your point. Names are changed. I will let Fabio know to change it in flow deploments as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added my comments
@adrian-wojcik I think all conversations are resolved, can you rebase, make sure CI checks pass, and re-request review? |
@Rafalz13 I fixed the pre-commit checks for you. Pls fix the tests and rebase and it should be good to go. |
Done. There is a risk that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some last comments
Co-authored-by: Michał Zawadzki <[email protected]>
Co-authored-by: Michał Zawadzki <[email protected]>
Co-authored-by: Michał Zawadzki <[email protected]>
Co-authored-by: Michał Zawadzki <[email protected]>
Co-authored-by: Michał Zawadzki <[email protected]>
Co-authored-by: Michał Zawadzki <[email protected]>
Co-authored-by: Michał Zawadzki <[email protected]>
Summary
Adds SQLServer connector
Checklist
This PR:
CONTRIBUTING.md
CHANGELOG.md