Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename #30

Merged
merged 2 commits into from
Oct 31, 2018
Merged

Rename #30

merged 2 commits into from
Oct 31, 2018

Conversation

femtotrader
Copy link
Contributor

@femtotrader femtotrader commented Oct 31, 2018

Closes #22
Closes #23
Should help #20

@codecov
Copy link

codecov bot commented Oct 31, 2018

Codecov Report

Merging #30 into master will decrease coverage by 29.94%.
The diff coverage is 85.71%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #30       +/-   ##
===========================================
- Coverage   87.41%   57.47%   -29.95%     
===========================================
  Files          13       14        +1     
  Lines         620      983      +363     
===========================================
+ Hits          542      565       +23     
- Misses         78      418      +340
Impacted Files Coverage Δ
src/ts.jl 77.08% <85.71%> (-22.92%) ⬇️
src/io.jl 12.9% <0%> (-71.31%) ⬇️
src/models.jl 50% <0%> (-35%) ⬇️
src/collapse.jl 64.78% <0%> (-33.09%) ⬇️
src/utils.jl 55.17% <0%> (-29.04%) ⬇️
src/show.jl 57.44% <0%> (-26.43%) ⬇️
src/operations.jl 61.24% <0%> (-24.63%) ⬇️
src/slice.jl 69.31% <0%> (-21.73%) ⬇️
src/indexing/stringrange.jl 67.77% <0%> (-18.28%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ebef6b...87e403d. Read the comment docs.

@femtotrader
Copy link
Contributor Author

odd codecov decrease!

@iblislin
Copy link

it's JuliaLang/julia#28192

@dysonance
Copy link
Owner

Awesome, thanks for the contribution @femtotrader! It seems like the coverage issue linked by @iblis17 is something a lot of people are experiencing and the devs are aware of it and working on it, so I don't see that being a blocker to merge this. Thanks again for the help guys.

@dysonance dysonance merged commit a194e33 into dysonance:master Oct 31, 2018
@femtotrader
Copy link
Contributor Author

I think we should continue the discussion we started JuliaQuant/MarketTechnicals.jl#93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants