version bump: 0.8.16; removed premature cleanup from generate systems;

dyonng · Apr 17, 2023 · 1af609d · 1af609d
1 parent 2d5f552
commit 1af609d
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## [0.8.16] 2023.04.17
+
+### Fixed
+
+- Spline Movement wasn't working due to premature cleanup
+
 ## [0.8.15] 2023.04.03
 
 ### Fixed

diff --git a/Runtime/Tweens/Systems/ApplySystems/Transform/TweenSplineMovementSystem.cs b/Runtime/Tweens/Systems/ApplySystems/Transform/TweenSplineMovementSystem.cs
@@ -32,7 +32,7 @@ protected override void OnUpdate()
                     {
                         var forward = math.normalize(tweenInfo.SplineTweenInfo.Spline.EvaluateTangent(splinePosition));
                         var up = tweenInfo.SplineTweenInfo.Spline.EvaluateUpVector(splinePosition);
-                        localTransformRef.ValueRW.Rotation = quaternion.LookRotation(forward, up);
+                        localTransformRef.ValueRW.Rotation = math.normalize(quaternion.LookRotation(forward, up));
                     }
                 }
             }

diff --git a/Runtime/Tweens/Systems/Control/Jobless/JoblessTweenGenerateSystem.cs b/Runtime/Tweens/Systems/Control/Jobless/JoblessTweenGenerateSystem.cs
@@ -53,7 +53,6 @@ protected override void OnUpdate()
                 info.SetTweenId(tween.Id);
                 info.SetTweenInfo(commandRef.ValueRO.GetTweenStart(), commandRef.ValueRO.GetTweenEnd());
 
-                commandRef.ValueRW.Cleanup();
                 ecb.AddComponent(entity, info);
                 ecb.RemoveComponent<TTweenCommand>(entity);
             }

diff --git a/Runtime/Tweens/Systems/Control/TweenGenerateSystem.cs b/Runtime/Tweens/Systems/Control/TweenGenerateSystem.cs
@@ -103,7 +103,6 @@ public void Execute(in ArchetypeChunk chunk, int chunkIndex, bool useEnabledMask
                     TTweenInfo info = default;
                     info.SetTweenId(tween.Id);
                     info.SetTweenInfo(command.GetTweenStart(), command.GetTweenEnd());
-                    command.Cleanup();
                     ParallelWriter.AddComponent(chunkIndex, entity, info);
                     ParallelWriter.RemoveComponent<TTweenCommand>(chunkIndex, entity);
                 }

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "com.dyonng.dotstween",
-    "version": "0.8.15",
+    "version": "0.8.16",
     "displayName": "DOTS Tween",
     "description": "Tween library for Unity ECS/DOTS.",
     "unity": "2022.2",