Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http): separate hostname and port before host checks #955

Merged
merged 2 commits into from
Oct 23, 2024
Merged

fix(http): separate hostname and port before host checks #955

merged 2 commits into from
Oct 23, 2024

Conversation

matteo-cristino
Copy link
Collaborator

  • fix(http): separate hostname and port before host checks
  • test(http): parse url with port

@jaromil
Copy link
Member

jaromil commented Oct 23, 2024

looks ok! _is_valid_host used now only in one place but makes sense to keep as function for readability

@jaromil jaromil merged commit 6a3acca into master Oct 23, 2024
27 checks passed
@jaromil jaromil deleted the fix/http_hostname branch October 23, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaromil jaromil Awaiting requested review from jaromil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matteo-cristino @jaromil