Added virtual fields OrderDeliveryAddressExternalId, OrderDeliveryAdd… #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ressExternalId, OrderDeliveryAddressLocationCode, OrderDeliveryAddressShipmentMethodCode, OrderDeliveryAddressShippingAgentCode and OrderDeliveryAddressShippingAgentServiceCode to store and handle DeliveryAddresses for orders, only OrderDeliveryAddressExternalId for import. Added logic for merging conditionals from EcomOrders to EcomOrderLines so when we only have one table mapping to EcomOrders it will merge else the conditionals will be skipped. Added left join on EcomOrders so we now fetch AccessUserAddress based on the OrderDeliveryAddressId. Updated PackageReference to 10.11 (not released yet) as the extra fields/virtuel-fields will be released on that version.
|
do not merge untill DW 10.11 is released (or wait for me to say it is ready) :) |
|
Can you merge with the last version of the OrderProvider because looks like it missed the changes from today :) |
MatthiasSort
commented
Nov 26, 2024
DWDBE
reviewed
Nov 26, 2024
DWDBE
reviewed
Nov 26, 2024
DWDBE
reviewed
Nov 26, 2024
DWDBE
reviewed
Nov 26, 2024
DWDBE
reviewed
Nov 26, 2024
DWDBE
reviewed
Nov 28, 2024
src/OrderProvider.cs
Outdated
| @@ -351,6 +380,7 @@ public override bool RunJob(Job job) | |||
| using (var reader = job.Source.GetReader(mapping)) | |||
| { | |||
| var columnMappings = new ColumnMappingCollection(MappingExtensions.ReplaceKeyColumnsWithAutoIdIfExists(mapping)); | |||
| FindColumnMappings(columnMappings); | |||
There was a problem hiding this comment.
it looks like the method is only needed for the EcomOrders tables mappings and not for the other tables so may be skipped for those that are not appropriate fx EcomOrderLines etc?
DWDBE
approved these changes
Nov 28, 2024
|
the fields will be saved directly on the order when an alternative address is selected in the UI, so changes in Order Provider is not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ressExternalId, OrderDeliveryAddressLocationCode, OrderDeliveryAddressShipmentMethodCode, OrderDeliveryAddressShippingAgentCode and OrderDeliveryAddressShippingAgentServiceCode to store and handle DeliveryAddresses for orders, only OrderDeliveryAddressExternalId for import. Added logic for merging conditionals from EcomOrders to EcomOrderLines so when we only have one table mapping to EcomOrders it will merge else the conditionals will be skipped. Added left join on EcomOrders so we now fetch AccessUserAddress based on the OrderDeliveryAddressId. Updated PackageReference to 10.11 (not released yet) as the extra fields/virtuel-fields will be released on that version.