Merge pull request #207 from dynamicslab/fix-set-params

BUG: SINDyDerivative set_params() missed sklearn interface
dynamicslab · Jun 21, 2022 · a7f94bf · a7f94bf
2 parents cbe47de + 7b16aec
commit a7f94bf
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/pysindy/differentiation/sindy_derivative.py b/pysindy/differentiation/sindy_derivative.py
@@ -52,7 +52,7 @@ def set_params(self, **params):
             # Simple optimization to gain speed (inspect is slow)
             return self
         else:
-            self.kwargs.update(params)
+            self.kwargs.update(params["kwargs"])
 
         return self
 

diff --git a/test/differentiation/test_differentiation_methods.py b/test/differentiation/test_differentiation_methods.py
@@ -262,6 +262,13 @@ def test_wrapper_equivalence_with_dxdt(data, derivative_kws):
         )
 
 
+def test_sindy_derivative_kwarg_update():
+    method = SINDyDerivative(kind="spectral", foo=2)
+    method.set_params(kwargs={"kind": "spline", "foo": 1})
+    assert method.kwargs["kind"] == "spline"
+    assert method.kwargs["foo"] == 1
+
+
 @pytest.mark.parametrize(
     "data, derivative_kws",
     [