Fixed order processing creating duplicate orders (#364)

- simplified some logic with finding or creating an order object
dynamic · Nov 19, 2018 · 9f56b5a · 9f56b5a
1 parent 6d91309
commit 9f56b5a
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/Controller/FoxyStripeController.php b/src/Controller/FoxyStripeController.php
@@ -73,13 +73,16 @@ public function handleDataFeed($encrypted, $decrypted)
         foreach ($orders->transactions->transaction as $transaction) {
             // if FoxyCart order id, then parse order
             if (isset($transaction->id)) {
-                ($order = Order::get()->filter('Order_ID', (int)$transaction->id)->First()) ?
-                    $order = Order::get()->filter('Order_ID', (int)$transaction->id)->First() :
+                $order = Order::get()->filter('Order_ID', (int)$transaction->id)->First();
+                if (!$order) {
                     $order = Order::create();
+                }
 
                 // save base order info
                 $order->Order_ID = (int)$transaction->id;
                 $order->Response = urlencode($encrypted);
+                // first write needed otherwise it creates a duplicates
+                $order->write();
                 $this->parseOrder($orders, $order);
                 $order->write();
             }