Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: retrieve da backend from genesis rollappparams #1002

Merged

Conversation

artemijspavlovs
Copy link
Collaborator

PR Standards

Opening a pull request should be able to meet the following requirements


For Author:

  • Targeted PR against correct branch
  • Included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case PR targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@artemijspavlovs artemijspavlovs requested a review from a team as a code owner September 19, 2024 07:12
@artemijspavlovs artemijspavlovs force-pushed the main branch 3 times, most recently from a4f07ac to a2397a5 Compare September 19, 2024 07:49
@artemijspavlovs artemijspavlovs force-pushed the artemijspavlovs/retrieve-da-backend-from-genesis branch 2 times, most recently from 5bdc0b6 to 34348e8 Compare September 19, 2024 07:57
fix(da): don't ask to override the existing da config
fix(wasm): add wasm vm type
fix: display the relevant information based on node type
chore: remove deprecated code
fix: fix outputs that require node type
fix(ui): installation spinner shouldn't draw new lines
@artemijspavlovs artemijspavlovs force-pushed the artemijspavlovs/retrieve-da-backend-from-genesis branch from 34348e8 to 6940865 Compare September 19, 2024 08:00
@artemijspavlovs artemijspavlovs merged commit 966f3ae into main Sep 19, 2024
2 checks passed
@artemijspavlovs artemijspavlovs deleted the artemijspavlovs/retrieve-da-backend-from-genesis branch September 19, 2024 08:33
artemijspavlovs pushed a commit that referenced this pull request Sep 20, 2024
Release-As: v1.7.0-alpha-pre-rc

chore: ci

chore(scripts): add version to roller installation script (#1007)

fix: retrieve da backend from genesis rollappparams (#1002)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

fix: retrieve rollapp binary commit from genesis (#1008)

Update bug-report.yaml

fix(block-explorer): improve flow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant