fix: Avoid panic on failure to fetch da account data (#232)

dymensionxyz · Jul 10, 2023 · b014553 · b014553
1 parent 65ba75c
commit b014553
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/data_layer/celestia/celestia.go b/data_layer/celestia/celestia.go
@@ -112,6 +112,12 @@ func (c *Celestia) getDAAccData(config.RollappConfig) (*utils.AccountData, error
 
 func (c *Celestia) GetDAAccData(cfg config.RollappConfig) ([]utils.AccountData, error) {
 	celAddress, err := c.getDAAccData(cfg)
+	if err != nil {
+		return nil, err
+	}
+	if celAddress == nil {
+		return nil, fmt.Errorf("failed to get DA account data")
+	}
 	return []utils.AccountData{*celAddress}, err
 }
 

diff --git a/utils/service_manager/service.go b/utils/service_manager/service.go
@@ -40,8 +40,8 @@ func (s *ServiceConfig) FetchServicesData(cfg config.RollappConfig) {
 		if service.FetchFn != nil {
 			accountData, err := service.FetchFn(cfg)
 			if err != nil {
-				//TODO: set the status to FAILED
-				return
+				s.Logger.Println(err)
+				continue
 			}
 			service.UIData.Accounts = accountData
 			if service.StatusFn != nil {