-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: use x/governors
instead of x/staking
#179
Conversation
Co-authored-by: github-actions <[email protected]>
Co-authored-by: Trinity <[email protected]> Co-authored-by: Omri <[email protected]>
Co-authored-by: anhductn2001 <[email protected]> Co-authored-by: github-actions <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved but not a fan of commenting out code, at all
please just delete instead, and leave a comment with a link to a github commit containing the commments
Or write todos
// "github.com/cosmos/cosmos-sdk/x/genutil" | ||
// genutiltypes "github.com/cosmos/cosmos-sdk/x/genutil/types" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we just delete instead of commenting
or if commenting out, needs a TODO: and an explanation
@@ -194,10 +195,10 @@ var ( | |||
ModuleBasics = module.NewBasicManager( | |||
auth.AppModuleBasic{}, | |||
authzmodule.AppModuleBasic{}, | |||
genutil.AppModuleBasic{}, | |||
// genutil.AppModuleBasic{}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto re commenting
// genutil.NewAppModule( | ||
// app.AccountKeeper, app.StakingKeeper, app.BaseApp.DeliverTx, | ||
// encodingConfig.TxConfig, | ||
// ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto re commenting
// TODO: read validators from sequencer modules | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why dont we do it in this PR?
@mtsitrin e2e tests fails. possibly due to genesis changes. |
@mtsitrin this change breaks the relayer. when trying to create an ibc connection, getting the following error (while trying to query for the unbonding period though it's defined in the genesis). I assume we need to route the staking grpc queries to the governors module:
This is one of the relevant parts from the relayer code:
In order to reproduce simply follow the extended readme until the point of |
closing for now until we decided the direction with that |
Description
Closes #XXX
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
godoc
commentsSDK Checklist
map
time.Now()
sendCoin
and notSendCoins
Full security checklist here
----;
For Reviewer:
---;
After reviewer approval: