Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(da): fixed da path seperator and encoding issue. #731

Merged
merged 4 commits into from
Apr 28, 2024

Conversation

omritoptix
Copy link
Contributor

PR Standards

Opening a pull request should be able to meet the following requirements


Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@omritoptix omritoptix marked this pull request as ready for review April 28, 2024 18:18
@omritoptix omritoptix requested a review from a team as a code owner April 28, 2024 18:18
@omritoptix omritoptix merged commit 3a3b219 into main Apr 28, 2024
3 of 5 checks passed
@omritoptix omritoptix deleted the omritoptix/730-da-path-fix branch April 28, 2024 18:31
omritoptix added a commit that referenced this pull request Apr 28, 2024
Co-authored-by: github-actions <[email protected]>
Co-authored-by: Sergi Rene <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants