Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mempool): set pre and post tx check funcs after genesis, not only after first block #691

Merged
merged 3 commits into from
Apr 17, 2024
Merged

fix(mempool): set pre and post tx check funcs after genesis, not only after first block #691

merged 3 commits into from
Apr 17, 2024

Conversation

danwt
Copy link
Contributor

@danwt danwt commented Apr 15, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

Close #662

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@danwt danwt requested a review from a team as a code owner April 15, 2024 14:20
@danwt danwt requested a review from mtsitrin April 15, 2024 15:56
zale144
zale144 reviewed Apr 15, 2024
View reviewed changes
state/executor.go Outdated Show resolved Hide resolved
@danwt danwt requested a review from zale144 April 16, 2024 08:10
zale144
zale144 previously approved these changes Apr 16, 2024
View reviewed changes
@danwt danwt requested a review from zale144 April 17, 2024 08:24
@mtsitrin mtsitrin merged commit 849ba80 into main Apr 17, 2024
4 checks passed
@mtsitrin mtsitrin deleted the danwt/662-always-use-mempool-pre-and-post-checks branch April 17, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtsitrin mtsitrin mtsitrin approved these changes

@zale144 zale144 Awaiting requested review from zale144

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mempool is initialized without the preCheck and postCheck functions at genesis
3 participants
@danwt @zale144 @mtsitrin