Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: full-node panics with app hash mismatch error when syncing #647

Merged
merged 3 commits into from
Apr 14, 2024

Conversation

srene
Copy link
Contributor

@srene srene commented Apr 12, 2024

PR Standards


This PR solves the issue running the RunInitChain func for botch sequencers and full-nodes to update the lastState, and starts syncing after that.

Close #643

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene requested a review from a team as a code owner April 12, 2024 16:22
@srene srene self-assigned this Apr 12, 2024
@srene srene marked this pull request as draft April 12, 2024 17:09
@srene srene marked this pull request as ready for review April 12, 2024 17:30
@omritoptix omritoptix merged commit 0073faf into main Apr 14, 2024
4 checks passed
@omritoptix omritoptix deleted the srene/643-fullnode-initchainer-fix branch April 14, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

initChainer should run for all nodes not just aggregator
2 participants