Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skew time using first block when no state update #1283

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

skew time using first block when no state update #1283

wants to merge 2 commits into from
+35 −40

Conversation

srene
Copy link
Contributor

@srene srene commented Dec 16, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A

Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene requested a review from a team as a code owner December 16, 2024 15:21
@srene srene linked an issue Dec 16, 2024 that may be closed by this pull request
skew time is using genesis creation time when there is no state update submitted. #1282
Open
omritoptix
omritoptix reviewed Dec 17, 2024
View reviewed changes
block/submit.go
@@ -314,11 +311,36 @@ func (m *Manager) UpdateLastSubmittedHeight(event pubsub.Message) {
}
}

func (m *Manager) GetLastBlockInSettlementTime() (time.Time, error) {
lastBlockInSettlement, err := m.Store.LoadBlock(m.LastSettlementHeight.Load())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the LastSettlementHeight may get pruned no?

pruningHeight = min(m.NextHeightToSubmit(), uint64(retainHeight))

if that's the case and we fallback to first block it may cause unnecessary halt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omritoptix omritoptix omritoptix left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
dym-internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

skew time is using genesis creation time when there is no state update submitted.
2 participants
@srene @omritoptix