Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(manager/p2p): tests fix for fraud validations #1124

Open
wants to merge 4 commits into
base: feat/adr-fraud-handling
Choose a base branch
from

Conversation

srene
Copy link
Contributor

@srene srene commented Oct 9, 2024

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #XXX

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene self-assigned this Oct 9, 2024
@srene srene requested a review from a team as a code owner October 9, 2024 07:57
@srene srene marked this pull request as draft October 9, 2024 08:01
@srene srene changed the title fix(p2p): p2p signature validation test fix fix(p2p): tests fix for fraud validations Oct 9, 2024
@srene srene changed the title fix(p2p): tests fix for fraud validations fix(manager/p2p): tests fix for fraud validations Oct 9, 2024
@srene srene marked this pull request as ready for review October 9, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant