Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manager): use block params from consensus param #1042

Merged
merged 19 commits into from
Sep 6, 2024
Merged

fix(manager): use block params from consensus param #1042

merged 19 commits into from
Sep 6, 2024

Conversation

srene
Copy link
Contributor

@srene srene commented Aug 26, 2024 •
edited
Loading

PR Standards

This PR refactors the rollapp params in dymint so max bytes is used again from consensus params + rollapp binary version field is renamed from commit to version

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A

Close #1064

<-- Briefly describe the content of this pull request -->

For Author:

  • Targeted PR against correct branch
  • included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • confirmed all author checklist items have been addressed

After reviewer approval:

  • In case targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@srene srene requested a review from a team as a code owner August 26, 2024 14:43
@srene srene marked this pull request as draft August 26, 2024 14:46
@srene srene self-assigned this Aug 26, 2024
@srene srene marked this pull request as ready for review August 26, 2024 16:40
@srene srene marked this pull request as draft August 27, 2024 07:21
@srene srene force-pushed the srene/rolapp_params_refactor branch from 8a73bb9 to c08492e Compare August 29, 2024 08:28
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 29, 2024
View reviewed changes
block/produce.go Fixed Show fixed Hide fixed
@srene srene marked this pull request as ready for review August 29, 2024 13:14
@srene srene marked this pull request as draft August 30, 2024 10:30
@srene srene force-pushed the srene/rolapp_params_refactor branch from 0bcddeb to 304d68a Compare August 30, 2024 10:31
@srene srene marked this pull request as ready for review August 30, 2024 10:32
@srene srene changed the title feat(manager): rollapp params rename + blockmaxgas to int64 feat(manager): rollapp params rename + use blockmaxgas from consensus param module Sep 2, 2024
@srene srene changed the title feat(manager): rollapp params rename + use blockmaxgas from consensus param module feat(manager): rollapp params rename + use block params from consensus param module Sep 6, 2024
omritoptix
omritoptix requested changes Sep 6, 2024
View reviewed changes
block/manager.go Outdated Show resolved Hide resolved
block/executor.go Outdated Show resolved Hide resolved
block/state.go Outdated Show resolved Hide resolved
block/state.go Outdated Show resolved Hide resolved
block/state.go Outdated Show resolved Hide resolved
omritoptix
omritoptix reviewed Sep 6, 2024
View reviewed changes
block/executor.go Outdated Show resolved Hide resolved
@omritoptix omritoptix changed the title feat(manager): rollapp params rename + use block params from consensus param module fix(manager): use block params from consensus param Sep 6, 2024
@omritoptix omritoptix merged commit 5de7192 into main Sep 6, 2024
6 checks passed
@omritoptix omritoptix deleted the srene/rolapp_params_refactor branch September 6, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omritoptix omritoptix omritoptix approved these changes

Assignees

@srene srene

Labels
dym-internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use block params only from consensus params
2 participants
@srene @omritoptix