fix(code standards): a few wrongly formatted error objects (#689)

da/avail/avail.go

@@ -310,7 +310,7 @@ func (c *DataAvailabilityLayerClient) submitBatchLoop(dataBlob []byte) da.Result
 func (c *DataAvailabilityLayerClient) broadcastTx(tx []byte) (uint64, error) {
  meta, err := c.client.GetMetadataLatest()
  if err != nil {
- return 0, fmt.Errorf("%s: %s", "failed to GetMetadataLatest", err)
+ return 0, fmt.Errorf("GetMetadataLatest: %w", err)
  }
  newCall, err := availtypes.NewCall(meta, DataCallSection+"."+DataCallMethod, availtypes.NewBytes(tx))
  if err != nil {
@@ -320,11 +320,11 @@ func (c *DataAvailabilityLayerClient) broadcastTx(tx []byte) (uint64, error) {
  ext := availtypes.NewExtrinsic(newCall)
  genesisHash, err := c.client.GetBlockHash(0)
  if err != nil {
- return 0, fmt.Errorf("%s: %s", "failed to GetBlockHash", err)
+ return 0, fmt.Errorf("GetBlockHash: %w", err)
  }
  rv, err := c.client.GetRuntimeVersionLatest()
  if err != nil {
- return 0, fmt.Errorf("%s: %s", "failed to GetRuntimeVersionLatest", err)
+ return 0, fmt.Errorf("GetRuntimeVersionLatest: %w", err)
  }
  keyringPair, err := signature.KeyringPairFromSecret(c.config.Seed, keyringNetworkID)
  if err != nil {
@@ -339,7 +339,7 @@ func (c *DataAvailabilityLayerClient) broadcastTx(tx []byte) (uint64, error) {
  var accountInfo availtypes.AccountInfo
  ok, err := c.client.GetStorageLatest(key, &accountInfo)
  if err != nil || !ok {
- return 0, fmt.Errorf("%s: %s", "failed to GetStorageLatest", err)
+ return 0, fmt.Errorf("GetStorageLatest: %w", err)
  }
 
  nonce := uint32(accountInfo.Nonce)
@@ -385,7 +385,7 @@ func (c *DataAvailabilityLayerClient) broadcastTx(tx []byte) (uint64, error) {
  hash := status.AsFinalized
  blockHeight, err := c.getHeightFromHash(hash)
  if err != nil {
- return 0, fmt.Errorf("%s: %s", "failed to getHeightFromHash", err)
+ return 0, fmt.Errorf("getHeightFromHash: %w", err)
  }
  return blockHeight, nil
  } else if status.IsInBlock {
@@ -395,7 +395,7 @@ func (c *DataAvailabilityLayerClient) broadcastTx(tx []byte) (uint64, error) {
  } else {
  recievedStatus, err := status.MarshalJSON()
  if err != nil {
- return 0, fmt.Errorf("%s: %s", "failed to MarshalJSON of received status", err)
+ return 0, fmt.Errorf("MarshalJSON of received status: %w", err)
  }
  c.logger.Debug("unsupported status, still waiting for inclusion", "status", string(recievedStatus))
  continue

p2p/utils_test.go

@@ -58,7 +58,7 @@ func getAddr(sk crypto.PrivKey) (multiaddr.Multiaddr, error) {
  copy(ip[net.IPv6len-len(suffix):], suffix)
  a, err := multiaddr.NewMultiaddr(fmt.Sprintf("/ip6/%s/tcp/4242", ip))
  if err != nil {
- return nil, fmt.Errorf("create test multiaddr: %s", err)
+ return nil, fmt.Errorf("create test multiaddr: %w", err)
  }
  return a, nil
 }

rpc/client/client.go

@@ -129,7 +129,7 @@ func (c *Client) BroadcastTxCommit(ctx context.Context, tx types.Tx) (*ctypes.Re
  }, mempool.TxInfo{})
  if err != nil {
  c.Logger.Error("Error on broadcastTxCommit", "err", err)
- return nil, fmt.Errorf("error on broadcastTxCommit: %v", err)
+ return nil, fmt.Errorf("error on broadcastTxCommit: %w", err)
  }
  select {
  case <-ctx.Done():

state/txindex/kv/kv.go

@@ -55,7 +55,7 @@ func (txi *TxIndex) Get(hash []byte) (*abci.TxResult, error) {
  txResult := new(abci.TxResult)
  err = proto.Unmarshal(rawBytes, txResult)
  if err != nil {
- return nil, fmt.Errorf("error reading TxResult: %v", err)
+ return nil, fmt.Errorf("error reading TxResult: %w", err)
  }
 
  return txResult, nil