Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typos in comments #554

Merged
merged 1 commit into from
Feb 8, 2024
Merged

fix: typos in comments #554

merged 1 commit into from
Feb 8, 2024

Conversation

GoodDaisy
Copy link
Contributor

Description

Fix typos in comments

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@GoodDaisy GoodDaisy requested a review from a team as a code owner February 8, 2024 04:10
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (34e2c3a) 30.71% compared to head (7a52928) 30.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #554   +/-   ##
=======================================
  Coverage   30.71%   30.71%           
=======================================
  Files         166      166           
  Lines       25719    25719           
=======================================
  Hits         7900     7900           
  Misses      16552    16552           
  Partials     1267     1267           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtsitrin mtsitrin merged commit 3b75e27 into dymensionxyz:main Feb 8, 2024
5 checks passed
omritoptix pushed a commit that referenced this pull request Feb 16, 2024
omritoptix pushed a commit that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants