Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: eIBC V1 #493

Merged
merged 71 commits into from
Feb 19, 2024
Merged

feat: eIBC V1 #493

merged 71 commits into from
Feb 19, 2024

Conversation

omritoptix
Copy link
Contributor

@omritoptix omritoptix commented Jan 21, 2024

Description

Following this feature overview: https://www.notion.so/dymension/eIBC-V1-Feature-Overview-396da8818d5e4ba1a74f2a3e0908582a?pvs=4


Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@omritoptix omritoptix requested a review from a team as a code owner January 21, 2024 12:58
@omritoptix omritoptix marked this pull request as draft January 21, 2024 12:59
@omritoptix omritoptix changed the title feat: EIBC V1 feat: eIBC V1 Jan 21, 2024
@omritoptix omritoptix linked an issue Jan 21, 2024 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Jan 21, 2024

Codecov Report

Attention: 2041 lines in your changes are missing coverage. Please review.

Comparison is base (cd821aa) 30.71% compared to head (3cfa8d5) 30.70%.
Report is 2 commits behind head on main.

Files Patch % Lines
x/eibc/types/tx.pb.go 3.33% 374 Missing and 3 partials ⚠️
x/eibc/types/query.pb.go 2.31% 337 Missing ⚠️
x/eibc/types/demand_order.pb.go 39.50% 245 Missing and 49 partials ⚠️
x/eibc/types/genesis.pb.go 1.08% 274 Missing ⚠️
x/eibc/types/params.pb.go 1.35% 219 Missing ⚠️
x/eibc/types/query.pb.gw.go 4.05% 70 Missing and 1 partial ⚠️
x/common/types/rollapp_packet.pb.go 23.21% 38 Missing and 5 partials ⚠️
x/eibc/keeper/invariants.go 33.84% 36 Missing and 7 partials ⚠️
x/eibc/keeper/keeper.go 71.12% 29 Missing and 12 partials ⚠️
x/eibc/client/cli/tx.go 0.00% 37 Missing ⚠️
... and 29 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
- Coverage   30.71%   30.70%   -0.02%     
==========================================
  Files         166      200      +34     
  Lines       25719    28460    +2741     
==========================================
+ Hits         7900     8738     +838     
- Misses      16552    18324    +1772     
- Partials     1267     1398     +131     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@omritoptix omritoptix marked this pull request as ready for review January 21, 2024 15:22
@omritoptix omritoptix marked this pull request as ready for review February 15, 2024 11:22
@omritoptix omritoptix marked this pull request as draft February 18, 2024 07:33
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@omritoptix omritoptix marked this pull request as ready for review February 18, 2024 15:32
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

if fullfillerAccount == nil {
return nil, types.ErrFullfillerAddressDoesNotExist
}
fullfillerBalance := m.BankKeeper.SpendableCoins(ctx, fullfillerAccount.GetAddress())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's already checked in the SendCoins

@omritoptix omritoptix merged commit 248650a into main Feb 19, 2024
4 of 7 checks passed
@omritoptix omritoptix deleted the omritoptix/490-eibc-v1 branch February 19, 2024 17:32
@VictorTrustyDev
Copy link
Contributor

Notion site page not found

omritoptix added a commit that referenced this pull request Feb 21, 2024
omritoptix added a commit that referenced this pull request Feb 21, 2024
omritoptix added a commit that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement eIBC V1
3 participants