feat: add pagination to sensitive endpoints

[zale144]

Description

---

Closes #1591

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Targeted PR against the correct branch
• included the correct type prefix in the PR title
• Linked to the GitHub issue with discussion and accepted design
• Targets only one GitHub issue
• Wrote unit and integration tests
• Wrote relevant migration scripts if necessary
• All CI checks have passed
• Added relevant godoc comments
• Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
• Add an issue in the e2e-tests repo if necessary

SDK Checklist

• Import/Export Genesis
• Registered Invariants
• Registered Events
• Updated openapi.yaml
• No usage of go map
• No usage of time.Now()
• Used fixed point arithmetic and not float arithmetic
• Avoid panicking in Begin/End block as much as possible
• No unexpected math Overflow
• Used sendCoin and not SendCoins
• Out-of-block compute is bounded
• No serialized ID at the end of store keys
• UInt to byte conversion should use BigEndian

Full security checklist here

---

For Reviewer:

• Confirmed the correct type prefix in the PR title
• Reviewers assigned
• Confirmed all author checklist items have been addressed

---

After reviewer approval:

• In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
• In case the PR targets a release branch, PR must be rebased.

[keruch]

good job! left just a few minor comments

[keruch]

this could be simpler. you can directly return commontypes.RollappPacket in transformFunc while paginating.

Suggested change

	// GetPendingPacketsByAddressPaginated retrieves rollapp packets from the KVStore by their receiver with pagination.
	func (k Keeper) GetPendingPacketsByAddressPaginated(ctx sdk.Context, receiver string, pageReq *query.PageRequest) (packets []commontypes.RollappPacket, pageResp *query.PageResponse, err error) {
	_, pageResp, err = collcompat.CollectionPaginate(ctx, k.pendingPacketsByAddress, pageReq,
	func(key collections.Pair[string, []byte], _ collections.NoValue) (bool, error) {
	packet, err := k.GetRollappPacket(ctx, string(key.K2()))
	if err != nil {
	return true, err
	}
	packets = append(packets, *packet)
	return false, nil
	}, collcompat.WithCollectionPaginationPairPrefix[string, []byte](receiver),
	)
	if err != nil {
	return nil, nil, err
	}
	return packets, pageResp, nil
	}
	// GetPendingPacketsByAddressPaginated retrieves rollapp packets from the KVStore by their receiver with pagination.
	func (k Keeper) GetPendingPacketsByAddressPaginated(ctx sdk.Context, receiver string, pageReq *query.PageRequest) ([]commontypes.RollappPacket, *query.PageResponse, error) {
	return collcompat.CollectionPaginate(ctx, k.pendingPacketsByAddress, pageReq,
	func(key collections.Pair[string, []byte], _ collections.NoValue) (commontypes.RollappPacket, error) {
	packet, err := k.GetRollappPacket(ctx, string(key.K2()))
	return *packet, err
	}, collcompat.WithCollectionPaginationPairPrefix[string, []byte](receiver),
	)
	}

[zale144]

packet, err := k.GetRollappPacket(ctx, string(key.K2()))
return *packet, err

packet could be nil though

[keruch]

i think you can skip the error check here

Suggested change

	func (k Keeper) GetAllRegisteredDenomsPaginated(ctx sdk.Context, rollappID string, pageReq *query.PageRequest) ([]string, *query.PageResponse, error) {
	denoms, pageRes, err := collcompat.CollectionPaginate(ctx, k.registeredRollappDenoms, pageReq,
	func(key collections.Pair[string, string], _ collections.NoValue) (string, error) {
	return key.K1(), nil
	}, collcompat.WithCollectionPaginationPairPrefix[string, string](rollappID),
	)
	if err != nil {
	return nil, nil, fmt.Errorf("paginate registered denoms: %w", err)
	}
	return denoms, pageRes, nil
	}
	func (k Keeper) GetAllRegisteredDenomsPaginated(ctx sdk.Context, rollappID string, pageReq *query.PageRequest) ([]string, *query.PageResponse, error) {
	return collcompat.CollectionPaginate(ctx, k.registeredRollappDenoms, pageReq,
	func(key collections.Pair[string, string], _ collections.NoValue) (string, error) {
	return key.K1(), nil
	}, collcompat.WithCollectionPaginationPairPrefix[string, string](rollappID),
	)
	}

[zale144]

why didn't I think of that

[keruch]

also, tests and linter are failing