-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rollapp): min bond is now defined on rollapp level #1579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
however I blv we should keep the min bond.
we can always set it to 0 at some point if we wish but I think it's good to start with sane min bond to protect unexperienced creators and maybe will change it later on.
@danwt I think we also need migration for this (as on mainnet it's defined now on global level). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1579 +/- ##
==========================================
- Coverage 22.61% 22.59% -0.02%
==========================================
Files 577 590 +13
Lines 127061 127609 +548
==========================================
+ Hits 28729 28829 +100
- Misses 94477 94911 +434
- Partials 3855 3869 +14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK LGTM!
@mtsitrin I'm considering your comments to be nits but I will change the param to adym |
Description
Closes #1577
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
godoc
commentsSDK Checklist
map
time.Now()
sendCoin
and notSendCoins
Full security checklist here
For Reviewer:
After reviewer approval: