Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bridging_fee): adding cacheCtx for charging fees #1563

Merged
merged 2 commits into from
Nov 28, 2024
Merged

fix(bridging_fee): adding cacheCtx for charging fees #1563

merged 2 commits into from
Nov 28, 2024

Conversation

mtsitrin
Copy link
Contributor

@mtsitrin mtsitrin commented Nov 27, 2024 •
edited
Loading

closes #1554

  • refactor charging fee implementation
  • charging fees in cacheCtx to allow clean failure

@mtsitrin mtsitrin linked an issue Nov 27, 2024 that may be closed by this pull request
Refactor bridging fee and add wrapped cached context #1554
Closed
@mtsitrin mtsitrin marked this pull request as ready for review November 27, 2024 10:49
@mtsitrin mtsitrin requested a review from a team as a code owner November 27, 2024 10:49
danwt
danwt previously approved these changes Nov 27, 2024
View reviewed changes
x/bridgingfee/ibc_module.go Outdated Show resolved Hide resolved
omritoptix
omritoptix previously approved these changes Nov 27, 2024
View reviewed changes
@mtsitrin mtsitrin dismissed stale reviews from omritoptix and danwt via 91700cf November 28, 2024 07:38
@mtsitrin mtsitrin merged commit 65cd290 into main Nov 28, 2024
4 checks passed
@mtsitrin mtsitrin deleted the 1554-refactor-bridging-fee-and-add-wrapped-cached-context branch November 28, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danwt danwt danwt left review comments

@omritoptix omritoptix omritoptix left review comments

Assignees
No one assigned
Labels
dym-internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor bridging fee and add wrapped cached context
3 participants
@mtsitrin @omritoptix @danwt