change rollapp tags map to list

dymensionxyz · Nov 28, 2024 · 60a187b · 60a187b
1 parent b313363
commit 60a187b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 17 deletions.
diff --git a/x/rollapp/keeper/grpc_query_rollapp.go b/x/rollapp/keeper/grpc_query_rollapp.go
@@ -99,11 +99,7 @@ func getSummaryResponse(ctx sdk.Context, k Keeper, rollapp types.Rollapp, ok, wi
 // Tags returns all the tags available for rollapps.
 // The order is non-deterministic.
 func (k Keeper) Tags(context.Context, *types.QueryTagsRequest) (*types.QueryTagsResponse, error) {
-	tags := make([]string, 0, len(types.RollappTags))
-	for tag := range types.RollappTags {
-		tags = append(tags, tag)
-	}
 	return &types.QueryTagsResponse{
-		Tags: tags,
+		Tags: types.RollappTags,
 	}, nil
 }
diff --git a/x/rollapp/types/rollapp.go b/x/rollapp/types/rollapp.go
@@ -4,6 +4,7 @@ import (
 	"errors"
 	"fmt"
 	"net/url"
+	"slices"
 	"strings"
 
 	errorsmod "cosmossdk.io/errors"
@@ -23,17 +24,17 @@ const (
 )
 
 // RollappTags are hardcoded for now TODO: manage them through the store
-var RollappTags = map[string]struct{}{
-	"Meme":      {},
-	"AI":        {},
-	"DeFI":      {},
-	"NFT":       {},
-	"Gaming":    {},
-	"Betting":   {},
-	"Community": {},
-	"Social":    {},
-	"DePIN":     {},
-	"Launchpad": {},
+var RollappTags = []string{
+	"Meme",
+	"AI",
+	"DeFI",
+	"NFT",
+	"Gaming",
+	"Betting",
+	"Community",
+	"Social",
+	"DePIN",
+	"Launchpad",
 }
 
 type AllowedDecimals uint32
@@ -253,7 +254,7 @@ func (md *RollappMetadata) Validate() error {
 	seen := make(map[string]struct{})
 
 	for _, tag := range md.Tags {
-		if _, ok := RollappTags[tag]; !ok {
+		if !slices.Contains(RollappTags, tag) {
 			return ErrInvalidTag
 		}
 		if _, ok := seen[tag]; ok {